Bug 103461 - Remove ASSERT_NOT_REACHED() from IDBCursorBackendImpl::postSuccessHandlerCallback()
Summary: Remove ASSERT_NOT_REACHED() from IDBCursorBackendImpl::postSuccessHandlerCall...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 45110
  Show dependency treegraph
 
Reported: 2012-11-27 16:01 PST by Michael Pruett
Modified: 2012-11-27 20:54 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.88 KB, patch)
2012-11-27 16:09 PST, Michael Pruett
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Pruett 2012-11-27 16:01:43 PST
In the Chromium port, IDBCursorBackendImpl::postSuccessHandlerCallback() is never invoked, but the ASSERT_NOT_REACHED() macro should be removed in order to allow IndexedDB to be implemented for JSC.
Comment 1 Michael Pruett 2012-11-27 16:09:17 PST
Created attachment 176356 [details]
Patch
Comment 2 Alec Flett 2012-11-27 16:29:13 PST
Comment on attachment 176356 [details]
Patch

if that's there, it almost always means that function is in the process of being removed. Why do you need it?
Comment 3 Joshua Bell 2012-11-27 16:34:28 PST
(In reply to comment #2)
> if that's there, it almost always means that function is in the process of being removed. Why do you need it?

I think it's part of the pre-fetching logic, but let me dig in. It's possible it's not even needed any more.
Comment 4 Joshua Bell 2012-11-27 16:41:17 PST
Yeah, Chromium code uses this to reset the prefetch cache if the success handler did anything other than continue().

It's safe to remove this ASSERT.
Comment 5 Kentaro Hara 2012-11-27 20:41:42 PST
Comment on attachment 176356 [details]
Patch

rs=me, per the discussion in the bug.
Comment 6 WebKit Review Bot 2012-11-27 20:54:50 PST
Comment on attachment 176356 [details]
Patch

Clearing flags on attachment: 176356

Committed r135969: <http://trac.webkit.org/changeset/135969>
Comment 7 WebKit Review Bot 2012-11-27 20:54:54 PST
All reviewed patches have been landed.  Closing bug.