INPUT_MULTIPLE_FIELDS_UI: Refactoring: Do not call updateInnerTextValue if only read-only sub-fields have values
Created attachment 175615 [details] Patch
Comment on attachment 175615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175615&action=review > LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html:23 > +shouldNotBe('eventSender.keyDown("upArrow"); getUserAgentShadowTextContent(input)', 'initialText'); Instead of shouldNotBe(), how about dumping the value of getUserAgentShadowTextContent(input) ? Given that you're dumping initialText, the test result is already platform-dependent.
Created attachment 175616 [details] Patch for landing
Comment on attachment 175615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175615&action=review >> LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html:23 >> +shouldNotBe('eventSender.keyDown("upArrow"); getUserAgentShadowTextContent(input)', 'initialText'); > > Instead of shouldNotBe(), how about dumping the value of getUserAgentShadowTextContent(input) ? Given that you're dumping initialText, the test result is already platform-dependent. Yeah, it's better for test result readability. The time formats in en-US locale on ICU/Windows/Mac are identical. We don't need to worry about platform dependency here.
Created attachment 175618 [details] Patch for landing
Comment on attachment 175618 [details] Patch for landing Clearing flags on attachment: 175618 Committed r135510: <http://trac.webkit.org/changeset/135510>
All reviewed patches have been landed. Closing bug.