Bug 102645 – input.value="" should clear date/time input elements with partial values

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

crbug.com/161443

If a page has <input type=date> with ENABLE_INPUT_MULTIPLE_FIELDS_UI and a user specifies a number only in one or two subfields (like [mm/13/yyyy]), input.value="" should clear the number.

[Kent Tamura]

Created attachment 174897 [details]
Patch

[WebKit Review Bot]

Comment on attachment 174897 [details]
Patch

Attachment 174897 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14894085

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

[Kentaro Hara]

Comment on attachment 174897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174897&action=review

> Source/WebCore/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Please add it.

> Source/WebCore/ChangeLog:20
> +        If the new value is an empty string and sub-fields has values, we should
> +        update the UI value to the empty state.

I want to understand this behavior more. What happens if you update the UI value to an empty state whenever the new value is an empty string?

[Kent Tamura]

Comment on attachment 174897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174897&action=review

>> Source/WebCore/ChangeLog:8
>> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
> 
> Please add it.

oops. I'll remove this line because the per-function comments are enough.

>> Source/WebCore/ChangeLog:20
>> +        update the UI value to the empty state.
> 
> I want to understand this behavior more. What happens if you update the UI value to an empty state whenever the new value is an empty string?

It's ok too.
However I'd like to avoid unnecessary UI update as possible because updateInnerTextValue is an expensive operation.

[Kentaro Hara]

Comment on attachment 174897 [details]
Patch

Thanks for the clarification. Makes sense to me.

[Kent Tamura]

Created attachment 174913 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 174913 [details]
Patch for landing

Clearing flags on attachment: 174913

Committed r135131: <http://trac.webkit.org/changeset/135131>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kentaro Hara]

I rebaselined the test result for Win in r135139. I think the rebaseline would be OK but I'd be happy if you could check it.

[Kentaro Hara]

Another rebaselining in r135147. (Maybe more rebaselining is needed. I'm leaving now:-)

[Kent Tamura]

Thank you for the rebaseline.  Yeah, these test results can be platform-dependent because of locale data differences.