Bug 102913 - [Shadow DOM] Kill ShadowRoot constructor
Summary: [Shadow DOM] Kill ShadowRoot constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on: 102911 104238 104770
Blocks: 63606
  Show dependency treegraph
 
Reported: 2012-11-21 02:51 PST by Hajime Morrita
Modified: 2012-12-16 20:57 PST (History)
12 users (show)

See Also:


Attachments
wip. need to update exported symbols. (210.79 KB, patch)
2012-12-10 03:59 PST, Hayato Ito
no flags Details | Formatted Diff | Diff
Update DOMWindow.idl (211.57 KB, patch)
2012-12-10 04:40 PST, Hayato Ito
no flags Details | Formatted Diff | Diff
further updating. (234.30 KB, patch)
2012-12-10 20:12 PST, Hayato Ito
no flags Details | Formatted Diff | Diff
fix a test on mac. (234.71 KB, patch)
2012-12-10 22:03 PST, Hayato Ito
no flags Details | Formatted Diff | Diff
relanding. (6.11 KB, patch)
2012-12-12 17:45 PST, Hayato Ito
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-11-21 02:51:27 PST
Once createShadowRoot() is implemented, we no longer need (and should not have) ShadowRoot constructor.
Comment 1 Hayato Ito 2012-12-10 03:59:50 PST
Created attachment 178510 [details]
wip. need to update exported symbols.
Comment 2 Hayato Ito 2012-12-10 04:40:21 PST
Created attachment 178518 [details]
Update DOMWindow.idl
Comment 3 Build Bot 2012-12-10 05:42:27 PST
Comment on attachment 178518 [details]
Update DOMWindow.idl

Attachment 178518 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15236485

New failing tests:
fast/frames/detached-shadow-frame.html
inspector/elements/shadow-root.html
Comment 4 WebKit Review Bot 2012-12-10 15:22:02 PST
Comment on attachment 178518 [details]
Update DOMWindow.idl

Attachment 178518 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15257304

New failing tests:
editing/shadow/breaking-editing-boundaries-2.html
fast/dom/shadow/insertion-point-resetStyleInheritance.html
editing/shadow/selection-of-shadowroot.html
inspector/elements/shadow-root.html
inspector/elements/update-shadowdom.html
editing/shadow/execcommand-indent-in-shadow.html
editing/shadow/insertorderedlist-crash.html
editing/shadow/delete-list-in-shadow.html
editing/shadow/contenteditable-propagation-at-shadow-boundary.html
editing/shadow/rightclick-on-meter-in-shadow-crash.html
editing/shadow/selection-of-orphan-shadowroot.html
editing/shadow/doubleclick-on-meter-in-shadow-crash.html
editing/shadow/shadow-selection-not-exported.html
editing/shadow/select-contenteditable-shadowhost.html
editing/shadow/pressing-enter-on-list.html
editing/shadow/adjusting-editing-boundary-with-table-in-shadow.html
editing/shadow/breaking-editing-boundaries.html
editing/shadow/delete-characters-in-distributed-node-crash.html
editing/shadow/compare-positions-in-nested-shadow.html
editing/shadow/breaking-editing-boundary-with-table.html
editing/shadow/bold-twice-in-shadow.html
Comment 5 Hayato Ito 2012-12-10 20:12:20 PST
Created attachment 178694 [details]
further updating.
Comment 6 Hayato Ito 2012-12-10 22:03:57 PST
Created attachment 178715 [details]
fix a test on mac.
Comment 7 WebKit Review Bot 2012-12-11 20:53:52 PST
Comment on attachment 178715 [details]
fix a test on mac.

Clearing flags on attachment: 178715

Committed r137408: <http://trac.webkit.org/changeset/137408>
Comment 8 WebKit Review Bot 2012-12-11 20:53:57 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 WebKit Review Bot 2012-12-11 23:22:39 PST
Re-opened since this is blocked by bug 104770
Comment 10 Hayato Ito 2012-12-12 17:45:08 PST
Created attachment 179163 [details]
relanding.
Comment 11 Hayato Ito 2012-12-12 17:47:08 PST
Let me re-land the patch after https://codereview.chromium.org/11548020/ is resolved.
Since I've not reverted the layout tests, this re-landing patch just deletes the constructor.


(In reply to comment #10)
> Created an attachment (id=179163) [details]
> relanding.
Comment 12 WebKit Review Bot 2012-12-16 20:57:43 PST
Comment on attachment 179163 [details]
relanding.

Clearing flags on attachment: 179163

Committed r137870: <http://trac.webkit.org/changeset/137870>
Comment 13 WebKit Review Bot 2012-12-16 20:57:48 PST
All reviewed patches have been landed.  Closing bug.