Bug 102911 - [Shadow DOM] Implement Element::createShadowRoot()
Summary: [Shadow DOM] Implement Element::createShadowRoot()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on: 103026
Blocks: 63606 102913
  Show dependency tree / graph
 
Reported: 2012-11-21 02:47 PST by Hajime Morrita
Modified: 2012-11-26 01:39 PST (History)
11 users (show)

See Also:

Attachments
Patch (5.38 KB, patch)
2012-11-21 17:23 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch for landing (6.22 KB, patch)
2012-11-22 00:37 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch for landing (6.29 KB, patch)
2012-11-25 17:47 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Hajime Morrita 2012-11-21 17:23:55 PST 
Created attachment 175553 [details]
Patch
Comment 2 Kentaro Hara 2012-11-21 17:27:12 PST 
Comment on attachment 175553 [details]
Patch

Looks OK
Comment 3 WebKit Review Bot 2012-11-21 19:15:56 PST 
Comment on attachment 175553 [details]
Patch

Clearing flags on attachment: 175553

Committed r135464: <http://trac.webkit.org/changeset/135464>
Comment 4 WebKit Review Bot 2012-11-21 19:16:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2012-11-21 21:55:11 PST 
(In reply to comment #3)
> (From update of attachment 175553 [details])
> Clearing flags on attachment: 175553
> 
> Committed r135464: <http://trac.webkit.org/changeset/135464>

It broke the GTK build as the EWS said ...
Comment 6 Hajime Morrita 2012-11-21 23:20:06 PST 
(In reply to comment #5)
> (In reply to comment #3)
> > (From update of attachment 175553 [details] [details])
> > Clearing flags on attachment: 175553
> > 
> > Committed r135464: <http://trac.webkit.org/changeset/135464>
> 
> It broke the GTK build as the EWS said ...
Ooops. Will fix. Thanks for  letting me know and I'm sorry for the breakage.
Comment 7 WebKit Review Bot 2012-11-21 23:28:31 PST 
Re-opened since this is blocked by bug 103026
Comment 8 Hajime Morrita 2012-11-22 00:37:26 PST 
Created attachment 175609 [details]
Patch for landing
Comment 9 Hajime Morrita 2012-11-22 00:37:52 PST 
Comment on attachment 175609 [details]
Patch for landing

Waiting gtk bot.
Comment 10 WebKit Review Bot 2012-11-25 17:15:00 PST 
Comment on attachment 175609 [details]
Patch for landing

Rejecting attachment 175609 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14984457
Comment 11 Hajime Morrita 2012-11-25 17:47:45 PST 
Created attachment 175904 [details]
Patch for landing
Comment 12 WebKit Review Bot 2012-11-26 01:39:30 PST 
Comment on attachment 175904 [details]
Patch for landing

Clearing flags on attachment: 175904

Committed r135693: <http://trac.webkit.org/changeset/135693>
Comment 13 WebKit Review Bot 2012-11-26 01:39:35 PST 
All reviewed patches have been landed.  Closing bug.