Bug 102806 - [V8] Introduce GenerateConstructorHeader() to CodeGeneratorV8.pm
Summary: [V8] Introduce GenerateConstructorHeader() to CodeGeneratorV8.pm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 102763
  Show dependency tree / graph
 
Reported: 2012-11-20 05:47 PST by Kentaro Hara
Modified: 2012-11-20 22:08 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.36 KB, patch)
2012-11-20 05:49 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-11-20 05:47:19 PST 
This is an incremental step for introducing constructorCallbackCustom(). See bug 102763.
Comment 1 Kentaro Hara 2012-11-20 05:49:10 PST 
Created attachment 175197 [details]
Patch
Comment 2 Adam Barth 2012-11-20 10:53:26 PST 
Comment on attachment 175197 [details]
Patch

ok
Comment 3 WebKit Review Bot 2012-11-20 15:42:57 PST 
Comment on attachment 175197 [details]
Patch

Clearing flags on attachment: 175197

Committed r135322: <http://trac.webkit.org/changeset/135322>
Comment 4 WebKit Review Bot 2012-11-20 15:43:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2012-11-20 22:02:56 PST 
(In reply to comment #3)
> (From update of attachment 175197 [details])
> Clearing flags on attachment: 175197
> 
> Committed r135322: <http://trac.webkit.org/changeset/135322>

It broke the bindings tests on the bots. Could you fix it?
Comment 6 Kentaro Hara 2012-11-20 22:04:35 PST 
(In reply to comment #5)
> (In reply to comment #3)
> > (From update of attachment 175197 [details] [details])
> > Clearing flags on attachment: 175197
> > 
> > Committed r135322: <http://trac.webkit.org/changeset/135322>
> 
> It broke the bindings tests on the bots. Could you fix it?

I think it I already fixed it. But it looks like another patch broke the test again. I'll fix it in mins.
Comment 7 Kentaro Hara 2012-11-20 22:08:10 PST 
(In reply to comment #6)
> > It broke the bindings tests on the bots. Could you fix it?
> 
> I think it I already fixed it. But it looks like another patch broke the test again. I'll fix it in mins.

Fixed in r135351.