Bug 102763 – [V8] Introduce constructorCallbackCustom()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

Currently custom constructors have the following code:

  v8::Handle<v8::Value> V8XXX::constructorCallback(const v8::Arguments& args) {
    INC_STATS("DOM.XXX.Constructor");
    if (!args.IsConstructCall())
      return throwTypeError("DOM object constructor cannot be called as a function.", args.GetIsolate());
    if (ConstructorMode::current() == ConstructorMode::WrapExistingObject)
      return args.Holder();

    /* body of the constructor */;
  }

I would like to generate the common part in a code generator so that custom constructors can just write the body part. Specifically, I want to make the following change:

  // Generated automatically
  v8::Handle<v8::Value> V8XXX::constructorCallback(const v8::Arguments& args) {
    INC_STATS("DOM.XXX.Constructor");
    if (!args.IsConstructCall())
      return throwTypeError("DOM object constructor cannot be called as a function.", args.GetIsolate());
    if (ConstructorMode::current() == ConstructorMode::WrapExistingObject)
      return args.Holder();

    V8XXX::constructorCallbackCustom(args);
  }

  // Written manually
  v8::Handle<v8::Value> V8XXX::constructorCallback(const v8::Arguments& args) {
    /* body of the constructor */;
  }

By doing this, not only can we avoid duplicating the same logic in custom bindings, but also it enables us to insert the logic for [V8MeasureAs] into custom constructors.

[Adam Barth]

Sounds good to me.

[Kentaro Hara]

Created attachment 175301 [details]
Patch

[Adam Barth]

Comment on attachment 175301 [details]
Patch

Very nice.

[Kentaro Hara]

Created attachment 175306 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 175306 [details]
patch for landing

Rejecting attachment 175306 [details] from commit-queue.

New failing tests:
fast/dom/call-a-constructor-as-a-function.html
Full output: http://queues.webkit.org/results/14933559

[Kentaro Hara]

Committed r135346: <http://trac.webkit.org/changeset/135346>

[Kentaro Hara]

(In reply to comment #5)
> New failing tests:
> fast/dom/call-a-constructor-as-a-function.html
> Full output: http://queues.webkit.org/results/14933559

Updated the test result and landed the patch. It looks like that '.' was missing in an error message of DataView's custom constructors:) Now we have '.' for all custom constructors because the same error message is generated by the code generator.