Bug 102751 - In CodeGeneratorGObject.pm we should rename $dataNode to $interface
Summary: In CodeGeneratorGObject.pm we should rename $dataNode to $interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-19 17:38 PST by Kentaro Hara
Modified: 2013-02-12 13:12 PST (History)
4 users (show)

See Also:

Attachments
Patch (8.91 KB, patch)
2012-11-19 17:39 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Initial patch (9.48 KB, patch)
2013-02-12 13:11 PST, Bear Travis 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-11-19 17:38:34 PST 
$dataNode is misnamed. It should be $interface.
Comment 1 Kentaro Hara 2012-11-19 17:39:20 PST 
Created attachment 175096 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-19 19:28:30 PST 
Comment on attachment 175096 [details]
Patch

Clearing flags on attachment: 175096

Committed r135235: <http://trac.webkit.org/changeset/135235>
Comment 3 WebKit Review Bot 2012-11-19 19:28:35 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Bear Travis 2013-02-12 13:11:13 PST 
Reopening to attach new patch.
Comment 5 Bear Travis 2013-02-12 13:11:15 PST 
Created attachment 187914 [details]
Initial patch

Implementing outside-shape layout, waiting to make it the default value until bug 109605.
Comment 6 Bear Travis 2013-02-12 13:12:37 PST 
Comment on attachment 187914 [details]
Initial patch

Accidental upload to the wrong bug. Reclosing.