Bug 102606 – Simulated mouse events should return an accurate offset.

• Status: RESOLVED
• Resolution: FIXED
• Component: UI Events

[Jon Lee]

The offset returned by simulated mouse events is the same as the page event because we skip recalculation of the offset for simulated events.

The check for this bit has been in the code since the KDE days, I believe. I think this check should be removed because that offset is now calculated from scratch and cached, whereas back in those days the offset was assigned directly to the event instance, and therefore it was inappropriate to make additional adjustments to the value.

See changelist 14916: http://trac.webkit.org/changeset/14916

[Jon Lee]

<rdar://problem/12725627>

[Jon Lee]

Created attachment 174843 [details]
Patch

[Brady Eidson]

Comment on attachment 174843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174843&action=review

> Source/WebCore/ChangeLog:10
> +        Remove an old check to avoid adjusting the offset location, because we now recalculate the
> +        offset from scratch and cache it.

It took me awhile to realize what you meant here.  I thought you were implying that this change also made us cache the offset.

Maybe clarify something like:
"Originally we did the isSimulated check.  Then sometime later, we started caching the offset.  I realized that caching the offset made the isSimulated check irrelevant, so lets remove it"

[Jon Lee]

(In reply to comment #3)
> (From update of attachment 174843 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174843&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        Remove an old check to avoid adjusting the offset location, because we now recalculate the
> > +        offset from scratch and cache it.
> 
> It took me awhile to realize what you meant here.  I thought you were implying that this change also made us cache the offset.
> 
> Maybe clarify something like:
> "Originally we did the isSimulated check.  Then sometime later, we started caching the offset.  I realized that caching the offset made the isSimulated check irrelevant, so lets remove it"

Yes, this needs better explanation. i will clarify in the submitted changelog.

[Jon Lee]

Committed r135065: <http://trac.webkit.org/changeset/135065>