Bug 102445 - DFG should copy propagate trivially no-op ConvertThis
Summary: DFG should copy propagate trivially no-op ConvertThis
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 102327
  Show dependency tree / graph
 
Reported: 2012-11-15 16:34 PST by Filip Pizlo
Modified: 2012-11-15 22:20 PST (History)
7 users (show)

See Also:

Attachments
the patch (7.50 KB, patch)
2012-11-15 16:43 PST, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-11-15 16:34:35 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2012-11-15 16:43:22 PST 
Created attachment 174556 [details]
the patch
Comment 2 Oliver Hunt 2012-11-15 16:49:49 PST 
Comment on attachment 174556 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174556&action=review

> Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp:713
>              ASSERT_NOT_REACHED();

CRASH()?
Comment 3 Filip Pizlo 2012-11-15 16:52:17 PST 
(In reply to comment #2)
> (From update of attachment 174556 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174556&action=review
> 
> > Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp:713
> >              ASSERT_NOT_REACHED();
> 
> CRASH()?

I will change.
Comment 4 Filip Pizlo 2012-11-15 22:20:48 PST 
Landed in http://trac.webkit.org/changeset/134896