RESOLVED FIXED 102327
Given a PutById or GetById with a proven structure, the DFG should be able to emit a PutByOffset or GetByOffset instead 
https://bugs.webkit.org/show_bug.cgi?id=102327
Summary Given a PutById or GetById with a proven structure, the DFG should be able to...
Filip Pizlo
Reported 2012-11-14 21:28:32 PST
This will be fun.
Attachments
work in progress (16.82 KB, patch)
2012-11-15 23:38 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
still working on it (31.32 KB, patch)
2012-11-16 13:21 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (34.11 KB, patch)
2012-11-16 17:56 PST, Filip Pizlo 		mhahnenberg: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-11-15 23:38:22 PST
Created attachment 174615 [details] work in progress
Filip Pizlo
Comment 2 2012-11-16 13:21:25 PST
Created attachment 174749 [details] still working on it
Filip Pizlo
Comment 3 2012-11-16 17:56:37 PST
Created attachment 174789 [details] the patch
Early Warning System Bot
Comment 4 2012-11-16 18:08:35 PST
Comment on attachment 174789 [details] the patch Attachment 174789 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14860469
Early Warning System Bot
Comment 5 2012-11-16 18:12:10 PST
Comment on attachment 174789 [details] the patch Attachment 174789 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14860470
Mark Hahnenberg
Comment 6 2012-11-16 18:36:28 PST
Comment on attachment 174789 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=174789&action=review r=me with build fixes. > Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:169 > + // Now before we do anything else, push the CFA forward over the PutById Should this be "...over the GetById" instead?
EFL EWS Bot
Comment 7 2012-11-16 20:18:51 PST
Comment on attachment 174789 [details] the patch Attachment 174789 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14880054
Filip Pizlo
Comment 8 2012-11-17 00:00:59 PST
(In reply to comment #6) > (From update of attachment 174789 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174789&action=review > > r=me with build fixes. > > > Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:169 > > + // Now before we do anything else, push the CFA forward over the PutById > > Should this be "...over the GetById" instead? Yup! Thanks for catching it!
Filip Pizlo
Comment 9 2012-11-17 00:38:29 PST
Landed in http://trac.webkit.org/changeset/135041
Note You need to log in before you can comment on or make changes to this bug.