Bug 102430 - IndexedDB: Propagate DOMRequestState to IndexedDB binding utility functions
Summary: IndexedDB: Propagate DOMRequestState to IndexedDB binding utility functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 45110
  Show dependency tree / graph
 
Reported: 2012-11-15 14:11 PST by Michael Pruett
Modified: 2012-11-16 12:57 PST (History)
6 users (show)

See Also:

Attachments
Propagate DOMRequestState to IndexedDB binding utility functions (15.88 KB, patch)
2012-11-15 14:52 PST, Michael Pruett 		abarth: review+
Details | Formatted Diff | Diff
Propagate DOMRequestState to IndexedDB binding utility functions (15.87 KB, patch)
2012-11-16 10:28 PST, Michael Pruett 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Pruett 2012-11-15 14:11:44 PST 
Currently the DOMRequestState maintained in IDBRequest is propagated to deserializeIDBValue() and idbKeyToScriptValue(). This approach is fine for the V8 implementation of the IDB binding utilities, but in order to implement the binding utilities for JSC, the DOMRequestState should be propagated to injectIDBKeyIntoScriptValue(), createIDBKeyFromScriptValueAndKeyPath(), and canInjectIDBKeyIntoScriptValue() as well.
Comment 1 Michael Pruett 2012-11-15 14:52:46 PST 
Created attachment 174525 [details]
Propagate DOMRequestState to IndexedDB binding utility functions
Comment 2 Alec Flett 2012-11-15 17:07:55 PST 
Comment on attachment 174525 [details]
Propagate DOMRequestState to IndexedDB binding utility functions

In general this LGTM, I wonder if we'll also have to stick in some Scope()'s as well. But for now, lets leave them out optimistically.
Comment 3 Adam Barth 2012-11-15 17:50:07 PST 
Comment on attachment 174525 [details]
Propagate DOMRequestState to IndexedDB binding utility functions

What is a DOMRequestState in JSC?  http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/js/DOMRequestState.h didn't find anything.
Comment 4 Michael Pruett 2012-11-15 18:01:32 PST 
(In reply to comment #3)
> (From update of attachment 174525 [details])
> What is a DOMRequestState in JSC?  http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/js/DOMRequestState.h didn't find anything.

I haven't yet submitted a patch adding the JSC implementation of DOMRequestState, but I envision it being fairly similar to the IDBJSContext class in Source/WebCore/bindings/js/IDBBindingUtilities.cpp in the most recent patch I submitted for <https://bugs.webkit.org/show_bug.cgi?id=45110>.
Comment 5 Adam Barth 2012-11-16 09:19:40 PST 
Comment on attachment 174525 [details]
Propagate DOMRequestState to IndexedDB binding utility functions

Ok, so it's basically the exec state.  Then this patch makes sense.
Comment 6 Michael Pruett 2012-11-16 10:28:34 PST 
Created attachment 174719 [details]
Propagate DOMRequestState to IndexedDB binding utility functions

I've updated ChangeLogs adding Adam Barth as the reviewer.
Comment 7 Joshua Bell 2012-11-16 10:35:20 PST 
Comment on attachment 174719 [details]
Propagate DOMRequestState to IndexedDB binding utility functions

FYI, the commit queue will automaticaly update the CLs with the reviewer if a committer checks cq+.
Comment 8 WebKit Review Bot 2012-11-16 12:57:07 PST 
Comment on attachment 174719 [details]
Propagate DOMRequestState to IndexedDB binding utility functions

Clearing flags on attachment: 174719

Committed r134989: <http://trac.webkit.org/changeset/134989>
Comment 9 WebKit Review Bot 2012-11-16 12:57:11 PST 
All reviewed patches have been landed.  Closing bug.