Bug 102282 - [chromium/mac] Fix drawing of buttons, checkboxes, radio boxes, and steppers when the page is scaled
Summary: [chromium/mac] Fix drawing of buttons, checkboxes, radio boxes, and steppers ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
: 102719 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-11-14 13:51 PST by Nico Weber
Modified: 2012-11-19 15:23 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.84 KB, patch)
2012-11-14 13:53 PST, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch (5.72 KB, patch)
2012-11-14 15:48 PST, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch (5.79 KB, patch)
2012-11-14 15:49 PST, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch (5.80 KB, patch)
2012-11-14 15:56 PST, Nico Weber 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2012-11-14 13:51:43 PST 
[chromium/mac] Fix drawing of buttons, checkboxes, radio boxes, and steppers when the page is scaled
Comment 1 Nico Weber 2012-11-14 13:53:14 PST 
Created attachment 174249 [details]
Patch
Comment 2 Nico Weber 2012-11-14 15:48:20 PST 
Created attachment 174273 [details]
Patch
Comment 3 Nico Weber 2012-11-14 15:49:35 PST 
Created attachment 174274 [details]
Patch
Comment 4 Nico Weber 2012-11-14 15:53:16 PST 
The chromium-side bug of this is http://crbug.com/161032
Comment 5 James Robinson 2012-11-14 15:53:25 PST 
Comment on attachment 174274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174274&action=review

> Source/WebCore/ChangeLog:14
> +        Covered by the new pixel test fast/forms/zoomed-controls.html. I
> +        couldn't find an existing test for this.

explains why it's been broken for so long, i suppose

> LayoutTests/fast/forms/zoomed-controls.html:1
> +<html>

<!DOCTYPE html> before this (unless you really want quirks mode)

> LayoutTests/platform/chromium/TestExpectations:4054
> +# Needs baselines
> +Bug(thakis) [ Release ] fast/forms/zoomed-controls.html [ ImageOnlyFailure ]

can you at least add some mac baselines?
Comment 6 Nico Weber 2012-11-14 15:56:05 PST 
Created attachment 174275 [details]
Patch
Comment 7 Nico Weber 2012-11-14 15:56:58 PST 
(In reply to comment #5)
> (From update of attachment 174274 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174274&action=review
> 
> > Source/WebCore/ChangeLog:14
> > +        Covered by the new pixel test fast/forms/zoomed-controls.html. I
> > +        couldn't find an existing test for this.
> 
> explains why it's been broken for so long, i suppose
> 
> > LayoutTests/fast/forms/zoomed-controls.html:1
> > +<html>
> 
> <!DOCTYPE html> before this (unless you really want quirks mode)

Done.

> 
> > LayoutTests/platform/chromium/TestExpectations:4054
> > +# Needs baselines
> > +Bug(thakis) [ Release ] fast/forms/zoomed-controls.html [ ImageOnlyFailure ]
> 
> can you at least add some mac baselines?

From what I understand, that won't match the bots anyway. I'll grab baselines from the bots as soon as possible. (If you just want to know how they look: http://i.imgur.com/0kR5o.png is the local -expected.png)
Comment 8 WebKit Review Bot 2012-11-14 17:12:19 PST 
Comment on attachment 174275 [details]
Patch

Clearing flags on attachment: 174275

Committed r134698: <http://trac.webkit.org/changeset/134698>
Comment 9 WebKit Review Bot 2012-11-14 17:12:22 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Eric Seidel (no email) 2012-11-19 15:23:52 PST 
*** Bug 102719 has been marked as a duplicate of this bug. ***