Bug 102270 – IndexedDB: Replace int64 with int64_t

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Michael Pruett]

There are currently two uses of the non-standard type int64 in IndexedDB which should be changed to the C99/C++11 int64_t type.

The int64 type is defined in Chromium's basictypes.h but is not defined for other platforms.

[Michael Pruett]

Created attachment 174228 [details]
Replace int64 with int64_t

[Tony Chang]

Comment on attachment 174228 [details]
Replace int64 with int64_t

View in context: https://bugs.webkit.org/attachment.cgi?id=174228&action=review

> Source/WebCore/ChangeLog:8
> +
> +        Tests: storage/indexeddb/*

Please put the reason for the change here. For example, "This is needed for JSC because ...".

[Joshua Bell]

> Please put the reason for the change here. For example, "This is needed for JSC because ...".

And "Cleaning up coding inconsistencies, no behavior change" is acceptable as a reason.

[Michael Pruett]

Created attachment 174242 [details]
Replace int64 with int64_t

[WebKit Review Bot]

Comment on attachment 174242 [details]
Replace int64 with int64_t

Rejecting attachment 174242 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
: Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Coordinated Graphics: Rename m_CoordinatedGraphicsLayerClient to m_coordinator

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 154.

Full output: http://queues.webkit.org/results/14832512

[WebKit Review Bot]

Comment on attachment 174242 [details]
Replace int64 with int64_t

Clearing flags on attachment: 174242

Committed r134673: <http://trac.webkit.org/changeset/134673>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.