Bug 102153 - [chromium] Remove the WebCompositorSupport virtual methods from the base class
Summary: [chromium] Remove the WebCompositorSupport virtual methods from the base class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on: 101968 102700
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-13 16:38 PST by Dana Jansens
Modified: 2012-11-19 17:22 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.92 KB, patch)
2012-11-13 16:38 PST, Dana Jansens 		no flags Details | Formatted Diff | Diff
Patch for landing (2.63 KB, patch)
2012-11-19 11:03 PST, Dana Jansens 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-11-13 16:38:13 PST 
[chromium] Remove the WebCompositorSupport virtual methods from the base class
Comment 1 Dana Jansens 2012-11-13 16:38:52 PST 
Created attachment 174025 [details]
Patch
Comment 2 Dana Jansens 2012-11-13 16:39:39 PST 
This also depends on https://codereview.chromium.org/11410075
Comment 3 WebKit Review Bot 2012-11-13 22:10:14 PST 
Comment on attachment 174025 [details]
Patch

Attachment 174025 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14831207
Comment 4 Peter Beverloo (cr-android ews) 2012-11-13 22:55:47 PST 
Comment on attachment 174025 [details]
Patch

Attachment 174025 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14826483
Comment 5 Dana Jansens 2012-11-17 08:50:14 PST 
Once chromium rolls into WebKit, this'll be ready to land. Can I get a review please?
Comment 6 WebKit Review Bot 2012-11-19 09:19:30 PST 
Comment on attachment 174025 [details]
Patch

Rejecting attachment 174025 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/chromium/tests/LinkHighlightTest.o
Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp: In constructor '<unnamed>::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest()':
Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp:63: error: 'class WebKit::WebCompositorSupport' has no member named 'setAcceleratedAnimationEnabled'
make: *** [out/Release/obj.target/webkit_unit_tests/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/14899255
Comment 7 Dana Jansens 2012-11-19 11:03:04 PST 
Created attachment 175007 [details]
Patch for landing
Comment 8 WebKit Review Bot 2012-11-19 11:23:34 PST 
Comment on attachment 175007 [details]
Patch for landing

Clearing flags on attachment: 175007

Committed r135180: <http://trac.webkit.org/changeset/135180>
Comment 9 WebKit Review Bot 2012-11-19 11:23:39 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 WebKit Review Bot 2012-11-19 11:57:44 PST 
Re-opened since this is blocked by bug 102700
Comment 12 Dana Jansens 2012-11-19 16:57:58 PST 
Comment on attachment 175007 [details]
Patch for landing

ui/compositor is fixed now. Chrome for ChromeOS is building locally. Let's try again.
Comment 13 WebKit Review Bot 2012-11-19 17:22:55 PST 
Comment on attachment 175007 [details]
Patch for landing

Clearing flags on attachment: 175007

Committed r135216: <http://trac.webkit.org/changeset/135216>
Comment 14 WebKit Review Bot 2012-11-19 17:22:59 PST 
All reviewed patches have been landed.  Closing bug.