[chromium] Remove the WebCompositorSupport methods for changing settings, plumb everything through WebLayerTreeSettings
Created attachment 173695 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Created attachment 173717 [details] Patch rebased
Comment on attachment 173717 [details] Patch Yes!
Comment on attachment 173717 [details] Patch Rejecting attachment 173717 [details] from commit-queue. New failing tests: compositing/reflections/animation-inside-reflection.html animations/matrix-anim.html animations/3d/matrix-transform-type-animation.html animations/change-transform-style-during-animation.html animations/3d/state-at-end-event-transform.html animations/big-rotation.html animations/additive-transform-animations.html animations/3d/replace-filling-transform.html animations/fill-mode-transform.html compositing/animation/state-at-end-event-transform-layer.html animations/animation-start-event-destroy-renderer.html compositing/animation/animation-compositing.html compositing/layer-creation/overlap-animation.html animations/animation-hit-test-transform.html animations/3d/change-transform-in-end-event.html animations/animation-direction-reverse-hardware.html animations/keyframe-timing-functions-transform.html animations/animation-matrix-negative-scale-unmatrix.html animations/3d/transform-perspective.html animations/animation-end-event-destroy-renderer.html animations/animation-direction-normal.html animations/combo-transform-rotate+scale.html animations/3d/transform-origin-vs-functions.html animations/animation-direction-reverse.html animations/animation-iteration-event-destroy-renderer.html animations/animation-direction-reverse-fill-mode-hardware.html animations/dynamic-stylesheet-loading.html animations/combo-transform-translate+scale.html animations/animation-direction-reverse-timing-functions-hardware.html compositing/reflections/nested-reflection-animated.html Full output: http://queues.webkit.org/results/14817427
evidently we do use accelerated animation in tests?
(In reply to comment #6) > evidently we do use accelerated animation in tests? It looks like this change may accidentally enable accelerated animation. I would expect timeouts as a symptom of that.
Comment on attachment 173717 [details] Patch Attachment 173717 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14811751 New failing tests: compositing/reflections/animation-inside-reflection.html animations/animation-direction-reverse.html animations/3d/matrix-transform-type-animation.html animations/change-transform-style-during-animation.html animations/3d/state-at-end-event-transform.html animations/big-rotation.html animations/additive-transform-animations.html animations/3d/replace-filling-transform.html animations/fill-mode-transform.html compositing/animation/state-at-end-event-transform-layer.html animations/animation-start-event-destroy-renderer.html compositing/animation/animation-compositing.html compositing/layer-creation/overlap-animation.html animations/animation-hit-test-transform.html animations/3d/change-transform-in-end-event.html animations/animation-direction-reverse-hardware.html animations/keyframe-timing-functions-transform.html animations/animation-matrix-negative-scale-unmatrix.html animations/missing-from-to-transforms.html animations/3d/transform-perspective.html animations/animation-end-event-destroy-renderer.html animations/animation-direction-normal.html animations/combo-transform-rotate+scale.html animations/3d/transform-origin-vs-functions.html animations/matrix-anim.html animations/animation-iteration-event-destroy-renderer.html animations/animation-direction-reverse-fill-mode-hardware.html animations/dynamic-stylesheet-loading.html animations/animation-direction-reverse-timing-functions-hardware.html compositing/reflections/nested-reflection-animated.html
Reverted r134446 for reason: Need to try a different strategy for landing a two-sided patch (3/3). Committed r134486: <http://trac.webkit.org/changeset/134486>
Created attachment 174023 [details] Patch
This now also depends on https://codereview.chromium.org/11361223/
Comment on attachment 174023 [details] Patch Attachment 174023 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14832220 New failing tests: compositing/reflections/animation-inside-reflection.html animations/matrix-anim.html animations/3d/matrix-transform-type-animation.html animations/change-transform-style-during-animation.html animations/3d/state-at-end-event-transform.html animations/big-rotation.html animations/additive-transform-animations.html animations/3d/replace-filling-transform.html animations/fill-mode-transform.html compositing/animation/state-at-end-event-transform-layer.html animations/animation-start-event-destroy-renderer.html compositing/animation/animation-compositing.html compositing/layer-creation/overlap-animation.html animations/animation-hit-test-transform.html animations/3d/change-transform-in-end-event.html animations/animation-direction-reverse-hardware.html animations/keyframe-timing-functions-transform.html animations/3d/transform-perspective.html animations/animation-end-event-destroy-renderer.html animations/animation-direction-normal.html animations/combo-transform-rotate+scale.html animations/3d/transform-origin-vs-functions.html animations/animation-direction-reverse.html animations/animation-iteration-event-destroy-renderer.html animations/animation-direction-reverse-fill-mode-hardware.html animations/dynamic-stylesheet-loading.html animations/combo-transform-translate+scale.html animations/animation-direction-reverse-timing-functions-hardware.html compositing/reflections/nested-reflection-animated.html
Created attachment 174453 [details] Patch rebase
This should be good to review/land now.
Comment on attachment 174453 [details] Patch Clearing flags on attachment: 174453 Committed r134850: <http://trac.webkit.org/changeset/134850>
All reviewed patches have been landed. Closing bug.