Bug 102126 – [Blackberry] Break suspend/resume of the backingstore and screen into separate methods

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Adam Treat]

Modify the suspend/resume methods so that they can be called from the UI thread itself and split up the suspend/resume methods so that we can suspend/resume the screen or backingstore separately.

[Adam Treat]

Created attachment 173967 [details]
WebKit portion of PR 219976

This has already been reviewed internally, but need upstream review.

[Antonio Gomes]

Comment on attachment 173967 [details]
WebKit portion of PR 219976

View in context: https://bugs.webkit.org/attachment.cgi?id=173967&action=review

> Source/WebKit/blackberry/ChangeLog:83
>  
>          [BlackBerry] Add a prompt to enable global location services
>          https://bugs.webkit.org/show_bug.cgi?id=100992
> -        
> +
>          PR 227897
>  
>          Reviewed by Rob Buis.

I am not sure commit queue will handle well all this unrelated changelog entries in your diff.

[Adam Treat]

(In reply to comment #2)
> (From update of attachment 173967 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173967&action=review
> 
> > Source/WebKit/blackberry/ChangeLog:83
> >  
> >          [BlackBerry] Add a prompt to enable global location services
> >          https://bugs.webkit.org/show_bug.cgi?id=100992
> > -        
> > +
> >          PR 227897
> >  
> >          Reviewed by Rob Buis.
> 
> I am not sure commit queue will handle well all this unrelated changelog entries in your diff.

I will get rid of the unnecessary changes to the Changelog, thanks!

[Adam Treat]

Comment on attachment 173967 [details]
WebKit portion of PR 219976

Get out of review queue since I need to fix the changelog.

[Adam Treat]

Created attachment 174161 [details]
WebKit portion of PR 219976 v2

Fixed the changelog

[Adam Treat]

Created attachment 174192 [details]
WebKit portion of PR 219976 v3

New version rebased on latest trunk so that it will apply cleanly.

[WebKit Review Bot]

Comment on attachment 174192 [details]
WebKit portion of PR 219976 v3

Clearing flags on attachment: 174192

Committed r134630: <http://trac.webkit.org/changeset/134630>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.