WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
100992
[BlackBerry] Add a prompt to enable global location services
https://bugs.webkit.org/show_bug.cgi?id=100992
Summary
[BlackBerry] Add a prompt to enable global location services
otcheung
Reported
2012-11-01 14:53:02 PDT
Currently, there is no check for the global location services setting. We need to add a prompt to ask the user to enable location services once per session if location services is turned off and the web page is requesting for it.
Attachments
Patch
(7.38 KB, patch)
2012-11-01 14:59 PDT
,
otcheung
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
otcheung
Comment 1
2012-11-01 14:59:07 PDT
Created
attachment 171939
[details]
Patch
Rob Buis
Comment 2
2012-11-01 15:07:21 PDT
Comment on
attachment 171939
[details]
Patch Looks good.
kov's GTK+ EWS bot
Comment 3
2012-11-01 15:27:35 PDT
Comment on
attachment 171939
[details]
Patch
Attachment 171939
[details]
did not pass gtk-ews (gtk): Output:
http://queues.webkit.org/results/14665167
WebKit Review Bot
Comment 4
2012-11-01 15:45:55 PDT
Comment on
attachment 171939
[details]
Patch Rejecting
attachment 171939
[details]
from commit-queue.
otcheung@rim.com
does not have committer permissions according to
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py
. - If you do not have committer rights please read
http://webkit.org/coding/contributing.html
for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Review Bot
Comment 5
2012-11-01 18:17:48 PDT
Comment on
attachment 171939
[details]
Patch Clearing flags on attachment: 171939 Committed
r133247
: <
http://trac.webkit.org/changeset/133247
>
WebKit Review Bot
Comment 6
2012-11-01 18:17:52 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug