Bug 102038 - [EFL] In ewk_tiled_backing_store_pre_render_region, the 'slicer' may be uninitialized
Summary: [EFL] In ewk_tiled_backing_store_pre_render_region, the 'slicer' may be unini...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: KyungTae Kim
URL:
Keywords:
Depends on:
Blocks: 101762
  Show dependency tree / graph
 
Reported: 2012-11-12 20:17 PST by KyungTae Kim
Modified: 2012-11-12 22:36 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.65 KB, patch)
2012-11-12 20:25 PST, KyungTae Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description KyungTae Kim 2012-11-12 20:17:04 PST 
In ewk_tiled_backing_store_pre_render_region, the member variables of 'slicer' are initialized in eina_tile_grid_slicer_setup,
and used in eina_tile_grid_slicer_next.

But, because some of them may be uninitialized, initialize it definitely with memset seems better.

It's for fixing the following build warning :

WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x: In function 'bool ewk_tiled_backing_store_pre_render_region(Evas_Object*, Evas_Coord, Evas_Coord, Evas_Coord, Evas_Coord, float)':

WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::tile_w' may be used uninitialized in this function [-Wuninitialized]

Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1857:27: note: 'slicer._Eina_Tile_Grid_Slicer::tile_w' was declared here

WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::w2_rel' may be used uninitialized in this function [-Wuninitialized]

Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1857:27: note: 'slicer._Eina_Tile_Grid_Slicer::w2_rel' was declared here
Comment 1 KyungTae Kim 2012-11-12 20:25:54 PST 
Created attachment 173802 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-12 22:36:39 PST 
Comment on attachment 173802 [details]
Patch

Clearing flags on attachment: 173802

Committed r134365: <http://trac.webkit.org/changeset/134365>
Comment 3 WebKit Review Bot 2012-11-12 22:36:43 PST 
All reviewed patches have been landed.  Closing bug.