Bug 101762 – [EFL] Turn on errors on warnings for WebKit1 and WebKit2 libraries

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Laszlo Gombos]

Introduce the following change and fix the resulting build failures...

Index: Source/CMakeLists.txt

 IF (ENABLE_WEBKIT)
-    WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebKit_LIBRARY_NAME})
+    WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebKit_LIBRARY_NAME} ${ADDITIONAL_FLAGS})
 ENDIF ()
 
 IF (ENABLE_WEBKIT2)
-    WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebKit2_LIBRARY_NAME})
+    WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebKit2_LIBRARY_NAME} ${ADDITIONAL_FLAGS})
 ENDIF ()

[Laszlo Gombos]

Would be great to look into this as well.

/build/WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::tile_w' may be used uninitialized in this function [-Wuninitialized]

/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::w2_rel' may be used uninitialized in this function [-Wuninitialized]

[KyungTae Kim]

The 2 warnings are false alarms.
In ewk_tiled_backing_store.cpp:1857,
Eina_Tile_Grid_Slicer slicer   is defined,
and is initialized through eina_tile_grid_slicer_setup 
but eina_tile_grid_slicer_next  doesn't know it is initialized.
I wonder whether additional initialization is needed here for fixing build warning.

WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x: In function 'bool ewk_tiled_backing_store_pre_render_region(Evas_Object*, Evas_Coord, Evas_Coord, Evas_Coord, Evas_Coord, float)':

WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::tile_w' may be used uninitialized in this function [-Wuninitialized]

Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1857:27: note: 'slicer._Eina_Tile_Grid_Slicer::tile_w' was declared here

WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::w2_rel' may be used uninitialized in this function [-Wuninitialized]

Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1857:27: note: 'slicer._Eina_Tile_Grid_Slicer::w2_rel' was declared here

[KyungTae Kim]

Created attachment 173619 [details]
Patch

[KyungTae Kim]

Comment on attachment 173619 [details]
Patch

It can make build error on 32bit build bot until the 2 warnings issue (that warnings are only occurred on 32bit build bot now) is resolved.

[Gyuyoung Kim]

Comment on attachment 173619 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173619&action=review

> ChangeLog:3
> +        [EFL]Turn on errors on warnings for WebKit1 and WebKit2 libraries

Add a space between [EFL] and Turn.

[KyungTae Kim]

Created attachment 173813 [details]
Patch

[WebKit Review Bot]

Comment on attachment 173813 [details]
Patch

Clearing flags on attachment: 173813

Committed r134368: <http://trac.webkit.org/changeset/134368>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.