Bug 101762 - [EFL] Turn on errors on warnings for WebKit1 and WebKit2 libraries
Summary: [EFL] Turn on errors on warnings for WebKit1 and WebKit2 libraries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: KyungTae Kim
URL:
Keywords:
Depends on: 102038
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-09 07:54 PST by Laszlo Gombos
Modified: 2012-11-12 22:55 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.37 KB, patch)
2012-11-12 04:42 PST, KyungTae Kim
no flags Details | Formatted Diff | Diff
Patch (1.38 KB, patch)
2012-11-12 21:40 PST, KyungTae Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2012-11-09 07:54:26 PST
Introduce the following change and fix the resulting build failures...

Index: Source/CMakeLists.txt

 IF (ENABLE_WEBKIT)
-    WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebKit_LIBRARY_NAME})
+    WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebKit_LIBRARY_NAME} ${ADDITIONAL_FLAGS})
 ENDIF ()
 
 IF (ENABLE_WEBKIT2)
-    WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebKit2_LIBRARY_NAME})
+    WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebKit2_LIBRARY_NAME} ${ADDITIONAL_FLAGS})
 ENDIF ()
Comment 1 Laszlo Gombos 2012-11-09 08:10:25 PST
Would be great to look into this as well.

/build/WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::tile_w' may be used uninitialized in this function [-Wuninitialized]

/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::w2_rel' may be used uninitialized in this function [-Wuninitialized]
Comment 2 KyungTae Kim 2012-11-12 01:46:28 PST
The 2 warnings are false alarms.
In ewk_tiled_backing_store.cpp:1857,
Eina_Tile_Grid_Slicer slicer   is defined,
and is initialized through eina_tile_grid_slicer_setup 
but eina_tile_grid_slicer_next  doesn't know it is initialized.
I wonder whether additional initialization is needed here for fixing build warning.

WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x: In function 'bool ewk_tiled_backing_store_pre_render_region(Evas_Object*, Evas_Coord, Evas_Coord, Evas_Coord, Evas_Coord, float)':

WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::tile_w' may be used uninitialized in this function [-Wuninitialized]

Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1857:27: note: 'slicer._Eina_Tile_Grid_Slicer::tile_w' was declared here

WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::w2_rel' may be used uninitialized in this function [-Wuninitialized]

Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1857:27: note: 'slicer._Eina_Tile_Grid_Slicer::w2_rel' was declared here
Comment 3 KyungTae Kim 2012-11-12 04:42:57 PST
Created attachment 173619 [details]
Patch
Comment 4 KyungTae Kim 2012-11-12 04:46:17 PST
Comment on attachment 173619 [details]
Patch

It can make build error on 32bit build bot until the 2 warnings issue (that warnings are only occurred on 32bit build bot now) is resolved.
Comment 5 Gyuyoung Kim 2012-11-12 21:26:54 PST
Comment on attachment 173619 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173619&action=review

> ChangeLog:3
> +        [EFL]Turn on errors on warnings for WebKit1 and WebKit2 libraries

Add a space between [EFL] and Turn.
Comment 6 KyungTae Kim 2012-11-12 21:40:39 PST
Created attachment 173813 [details]
Patch
Comment 7 WebKit Review Bot 2012-11-12 22:55:41 PST
Comment on attachment 173813 [details]
Patch

Clearing flags on attachment: 173813

Committed r134368: <http://trac.webkit.org/changeset/134368>
Comment 8 WebKit Review Bot 2012-11-12 22:55:46 PST
All reviewed patches have been landed.  Closing bug.