Bug 102017 - DFG CreateThis should be able to statically account for the structure of the object it creates, if profiling indicates that this structure is always the same
Summary: DFG CreateThis should be able to statically account for the structure of the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 102016 102047 102062
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-12 17:20 PST by Filip Pizlo
Modified: 2012-11-13 23:27 PST (History)
7 users (show)

See Also:

Attachments
work in progress (12.77 KB, patch)
2012-11-13 01:11 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (21.55 KB, patch)
2012-11-13 14:01 PST, Filip Pizlo 		ggaren: review-
Details | Formatted Diff | Diff
the patch (21.99 KB, patch)
2012-11-13 14:41 PST, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-11-12 17:20:17 PST 
I will hack this up after https://bugs.webkit.org/show_bug.cgi?id=102016 lands.
Comment 1 Filip Pizlo 2012-11-13 01:11:37 PST 
Created attachment 173848 [details]
work in progress
Comment 2 Filip Pizlo 2012-11-13 14:01:23 PST 
Created attachment 173981 [details]
the patch
Comment 3 Geoffrey Garen 2012-11-13 14:09:21 PST 
Comment on attachment 173981 [details]
the patch

I think you missed a clear inside defineOwnProperty().
Comment 4 Filip Pizlo 2012-11-13 14:14:39 PST 
(In reply to comment #3)
> (From update of attachment 173981 [details])
> I think you missed a clear inside defineOwnProperty().

Good catch!  Will fix.
Comment 5 Filip Pizlo 2012-11-13 14:41:13 PST 
Created attachment 173992 [details]
the patch
Comment 6 Geoffrey Garen 2012-11-13 14:49:40 PST 
Comment on attachment 173992 [details]
the patch

r=me
Comment 7 Filip Pizlo 2012-11-13 23:27:56 PST 
Landed in http://trac.webkit.org/changeset/134555