Bug 102016 – The act of getting the callee during 'this' construction should be explicit in bytecode

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

This will allow us to profile the callee.

[Filip Pizlo]

Created attachment 173768 [details]
the patch

[WebKit Review Bot]

Attachment 173768 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:462:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:465:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Saboff]

Comment on attachment 173768 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173768&action=review

r=me

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:-2127
> -            set(currentInstruction[1].u.operand, addToGraph(CreateThis, get(JSStack::Callee)));

Check and remove other magic from get(JSStack::Callee) prior change.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/134361