Bug 102016 - The act of getting the callee during 'this' construction should be explicit in bytecode
Summary: The act of getting the callee during 'this' construction should be explicit i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 102017 102047
  Show dependency treegraph
 
Reported: 2012-11-12 17:13 PST by Filip Pizlo
Modified: 2012-11-12 22:06 PST (History)
8 users (show)

See Also:


Attachments
the patch (11.39 KB, patch)
2012-11-12 17:20 PST, Filip Pizlo
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-11-12 17:13:50 PST
This will allow us to profile the callee.
Comment 1 Filip Pizlo 2012-11-12 17:20:46 PST
Created attachment 173768 [details]
the patch
Comment 2 WebKit Review Bot 2012-11-12 17:26:25 PST
Attachment 173768 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:462:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:465:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Saboff 2012-11-12 17:30:47 PST
Comment on attachment 173768 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173768&action=review

r=me

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:-2127
> -            set(currentInstruction[1].u.operand, addToGraph(CreateThis, get(JSStack::Callee)));

Check and remove other magic from get(JSStack::Callee) prior change.
Comment 4 Filip Pizlo 2012-11-12 22:06:03 PST
Landed in http://trac.webkit.org/changeset/134361