Bug 101900 - changing pseudoClass (:enabled) should cause distribution
Summary: changing pseudoClass (:enabled) should cause distribution
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks: 100451
  Show dependency tree / graph
 
Reported: 2012-11-11 23:13 PST by Shinya Kawanaka
Modified: 2012-11-15 19:55 PST (History)
6 users (show)

See Also:

Attachments
Patch (28.87 KB, patch)
2012-11-15 18:17 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-11-11 23:13:20 PST 
When these pseudo classes are changed, we should invalidate distribution.
Comment 1 Shinya Kawanaka 2012-11-15 18:17:08 PST 
Created attachment 174582 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2012-11-15 19:03:54 PST 
Comment on attachment 174582 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174582&action=review

> Source/WebCore/html/HTMLFormControlElement.cpp:154
> +    invalidateParentDistributionIfNecessary(this, SelectRuleFeatureSet::RuleFeatureDisabled | SelectRuleFeatureSet::RuleFeatureEnabled);

Wait... how can it be both enabled and disabled?
Comment 3 Shinya Kawanaka 2012-11-15 19:30:45 PST 
(In reply to comment #2)
> (From update of attachment 174582 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174582&action=review
> 
> > Source/WebCore/html/HTMLFormControlElement.cpp:154
> > +    invalidateParentDistributionIfNecessary(this, SelectRuleFeatureSet::RuleFeatureDisabled | SelectRuleFeatureSet::RuleFeatureEnabled);
> 
> Wait... how can it be both enabled and disabled?

This is just a mask. When either :disabled or :enabled is collected, we invalidate distribution.
Comment 4 Shinya Kawanaka 2012-11-15 19:36:02 PST 
Comment on attachment 174582 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174582&action=review

>>> Source/WebCore/html/HTMLFormControlElement.cpp:154
>>> +    invalidateParentDistributionIfNecessary(this, SelectRuleFeatureSet::RuleFeatureDisabled | SelectRuleFeatureSet::RuleFeatureEnabled);
>> 
>> Wait... how can it be both enabled and disabled?
> 
> This is just a mask. When either :disabled or :enabled is collected, we invalidate distribution.

So it cannot be both 'enabled' and 'disabled'.
Comment 5 WebKit Review Bot 2012-11-15 19:55:10 PST 
Comment on attachment 174582 [details]
Patch

Clearing flags on attachment: 174582

Committed r134883: <http://trac.webkit.org/changeset/134883>
Comment 6 WebKit Review Bot 2012-11-15 19:55:15 PST 
All reviewed patches have been landed.  Closing bug.