Bug 101891 - Create SelectRuleFeatureSet for collecting RuleFeatureSet for select attribute
Summary: Create SelectRuleFeatureSet for collecting RuleFeatureSet for select attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks: 100451
  Show dependency treegraph
 
Reported: 2012-11-11 21:58 PST by Shinya Kawanaka
Modified: 2012-11-12 14:50 PST (History)
4 users (show)

See Also:


Attachments
Patch (19.12 KB, patch)
2012-11-11 22:47 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (19.15 KB, patch)
2012-11-11 23:25 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-11-11 21:58:31 PST
Since RuleFeatureSet for select attribute will have more features than RuleFeatureSet has, it would be better to create another class.
We would like to collect the following features.
  :checked
  :enabled
  :disabled
  :indeterminate
  :link
  :target
  :visited
etc.
Comment 1 Shinya Kawanaka 2012-11-11 22:47:22 PST
Created attachment 173562 [details]
Patch
Comment 2 Build Bot 2012-11-11 23:07:54 PST
Comment on attachment 173562 [details]
Patch

Attachment 173562 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14787966
Comment 3 Shinya Kawanaka 2012-11-11 23:25:27 PST
Created attachment 173570 [details]
Patch
Comment 4 Hajime Morrita 2012-11-11 23:29:10 PST
Comment on attachment 173570 [details]
Patch

Let's wait greens.
Comment 5 WebKit Review Bot 2012-11-12 05:55:27 PST
Comment on attachment 173570 [details]
Patch

Clearing flags on attachment: 173570

Committed r134219: <http://trac.webkit.org/changeset/134219>
Comment 6 WebKit Review Bot 2012-11-12 05:55:31 PST
All reviewed patches have been landed.  Closing bug.