Bug 101737 – Web Inspector: Timeline: fix test expectations

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

The expected order of timeline records of specific types has been changed:
https://bugs.webkit.org/show_bug.cgi?id=101544

This change fixes test expectations.

Created attachment 173255 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 173255 [details]
Patch

You may want to update TestExpectations as well.

(In reply to comment #2)
> (From update of attachment 173255 [details])
> You may want to update TestExpectations as well.

OK.

Test was marked as text-flaky on 03'Jul but reason wasn't specified.

Created attachment 173264 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 173255 [details] [details])
> > You may want to update TestExpectations as well.
> 
> OK.
> 
> Test was marked as text-flaky on 03'Jul but reason wasn't specified.

What about Mac and Wind bots, does it pass there? If so then the expectations will be wrong for those platforms after this change.

(In reply to comment #5)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (From update of attachment 173255 [details] [details] [details])
> > > You may want to update TestExpectations as well.
> > 
> > OK.
> > 
> > Test was marked as text-flaky on 03'Jul but reason wasn't specified.
> 
> What about Mac and Wind bots, does it pass there? If so then the expectations will be wrong for those platforms after this change.

This expectations should work for all platforms.

Before the change we got "Send Request" arriving in timeline before enclosing record.

The tested scenario is: cause "send request", when data arrives, cause second "send request" from within notification event.

So, before the change "send request" record arrived before second "function call" and before the first (notification) "event".

That resulted the following sequence: function call, send request A ->, function call A, send request B ->, event B, event

After change "send request" should arrive after enclosing record. As a result we get: function call, function call A, <- send request A, event B, <- send request B, event

This order should be platform independent, because all events are explicitly chained (except first function call).

I believe Mac and Win bots will be happy.

[Csaba Osztrogonác]

Comment on attachment 173264 [details]
Patch

Clearing flags on attachment: 173264

Committed r134212: <http://trac.webkit.org/changeset/134212>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.