Bug 101544 – Web Inspector: Timeline: "Send Request" events are shown out of order.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

Created attachment 172932 [details]
Out-of-order records

Historically "Send Request" records are pushed out of order to make them top-level.

Nowadays frontend is responsible for changing parent of records.

Replacing backend out-of-order pushing with frontend reparenting makes record appear in-order.

Created attachment 172933 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 172933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172933&action=review

> Source/WebCore/ChangeLog:8
> +        Solution: replace obsolete out-of-order record pushing with forntend

Can we test this in layout tests?

Comment on attachment 172933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172933&action=review

>> Source/WebCore/ChangeLog:8
>> +        Solution: replace obsolete out-of-order record pushing with forntend
> 
> Can we test this in layout tests?

Done

Created attachment 172960 [details]
Patch

[WebKit Review Bot]

Comment on attachment 172960 [details]
Patch

Rejecting attachment 172960 [details] from commit-queue.

New failing tests:
fast/repaint/selection-after-delete.html
Full output: http://queues.webkit.org/results/14775142

[WebKit Review Bot]

Comment on attachment 172960 [details]
Patch

Clearing flags on attachment: 172960

Committed r134023: <http://trac.webkit.org/changeset/134023>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[János Badics]

This modification caused a test (inspector/timeline/timeline-receive-response-event.html) fail on Qt with the following diff:

--- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/timeline/timeline-receive-response-event-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/timeline/timeline-receive-response-event-actual.txt 
@@ -1,10 +1,6 @@
 Tests the Timeline API instrumentation of a SendRequest, ReceiveResponse etc.
 
 FunctionCall
-ResourceSendRequest
-    ResourceReceiveResponse
-    ResourceReceivedData
-    ResourceFinish
 FunctionCall
 ResourceSendRequest
     ResourceReceiveResponse
@@ -12,6 +8,10 @@
     ResourceFinish
 EventDispatch
     FunctionCall
+ResourceSendRequest
+    ResourceReceiveResponse
+    ResourceReceivedData
+    ResourceFinish
 EventDispatch
     FunctionCall

I'm not sure if it's a correct result or not; is it a problem if this part of code is written at different line number?

[Csaba Osztrogonác]

Unfortunately we don't know what happens on other ports, because
this test is skipped on all ports because of different reason.

(In reply to comment #9)
> Unfortunately we don't know what happens on other ports, because
> this test is skipped on all ports because of different reason.

I've fixed test:
https://bugs.webkit.org/show_bug.cgi?id=101737