Bug 101699 - Changing pseudoClass (:target) is changed, we should invalidate distribution.
Summary: Changing pseudoClass (:target) is changed, we should invalidate distribution.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks: 100451
  Show dependency tree / graph
 
Reported: 2012-11-08 20:50 PST by Shinya Kawanaka
Modified: 2012-11-14 01:28 PST (History)
4 users (show)

See Also:

Attachments
WIP (17.45 KB, patch)
2012-11-13 00:21 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Patch (6.90 KB, patch)
2012-11-13 22:27 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Patch (6.42 KB, patch)
2012-11-14 00:48 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-11-08 20:50:54 PST 
When :target pseudoClass is dynamically changed, we should invalidate distribution.

# I have to investigate how to cause this...
Comment 1 Shinya Kawanaka 2012-11-13 00:21:31 PST 
Created attachment 173838 [details]
WIP
Comment 2 Shinya Kawanaka 2012-11-13 00:22:13 PST 
This patch also contains a patch for Bug 101903, since this is dependent to it.
Comment 3 Shinya Kawanaka 2012-11-13 22:27:57 PST 
Created attachment 174078 [details]
Patch
Comment 4 Hajime Morrita 2012-11-13 23:43:05 PST 
Comment on attachment 174078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174078&action=review

> Source/WebCore/dom/ElementShadow.cpp:276
> +    case SelectRuleFeatureSet::RuleFeatureChecked:

We could have a helper method which tells us whether we need invalidateDistribution() call.
Comment 5 Shinya Kawanaka 2012-11-14 00:48:06 PST 
Created attachment 174095 [details]
Patch
Comment 6 Shinya Kawanaka 2012-11-14 00:48:52 PST 
(In reply to comment #4)
> (From update of attachment 174078 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174078&action=review
> 
> > Source/WebCore/dom/ElementShadow.cpp:276
> > +    case SelectRuleFeatureSet::RuleFeatureChecked:
> 
> We could have a helper method which tells us whether we need invalidateDistribution() call.

Done. hasSelectorFor() is suitable for this purpose.
Comment 7 WebKit Review Bot 2012-11-14 01:28:44 PST 
Comment on attachment 174095 [details]
Patch

Clearing flags on attachment: 174095

Committed r134572: <http://trac.webkit.org/changeset/134572>
Comment 8 WebKit Review Bot 2012-11-14 01:28:47 PST 
All reviewed patches have been landed.  Closing bug.