Bug 101637 - Remove ReadWriteLock
Summary: Remove ReadWriteLock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-08 13:18 PST by Laszlo Gombos
Modified: 2012-11-19 15:48 PST (History)
5 users (show)

See Also:


Attachments
1st try (4.70 KB, patch)
2012-11-08 13:48 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2012-11-08 13:18:52 PST
It seems ReadWriteLock is not used and it is only implemented for some environments so it requires some #if maintenance. Perhaps we should remove it (or find some use for it).
Comment 1 Laszlo Gombos 2012-11-08 13:31:45 PST
A related discussion from 3 years ago suggests the possibility of removing this class as well - https://bugs.webkit.org/show_bug.cgi?id=30713#c4
Comment 2 Laszlo Gombos 2012-11-08 13:48:08 PST
Created attachment 173111 [details]
1st try
Comment 3 Darin Adler 2012-11-13 10:38:13 PST
Comment on attachment 173111 [details]
1st try

Should be fine.
Comment 4 WebKit Review Bot 2012-11-19 15:47:58 PST
Comment on attachment 173111 [details]
1st try

Clearing flags on attachment: 173111

Committed r135206: <http://trac.webkit.org/changeset/135206>
Comment 5 WebKit Review Bot 2012-11-19 15:48:01 PST
All reviewed patches have been landed.  Closing bug.