Bug 30713 – Disable ReadWriteLock on platforms using pthreads but which do not support pthread_rwlock

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Steve Block]

ReadWriteLock is currently used only on SnowLeopard. See http://trac.webkit.org/changeset/44651. It is therefore implemented only on platforms using pthreads.

However, some platforms that use pthreads (eg Android) do not support pthread_rwlock. For these platforms, ReadWriteLock should be disabled.

[Steve Block]

Created attachment 41723 [details]
Patch 1 for Bug 30713

[Eric Seidel (no email)]

Comment on attachment 41723 [details]
Patch 1 for Bug 30713

This looks sane to me, but whoever added the ReadWriteLock stuff should really review/comment here.

[Mark Rowe (bdash)]

It’s not used anywhere.  I suspect it was added for a short-lived experiment, and that we can now rip it out completely.

[Darin Adler]

Comment on attachment 41723 [details]
Patch 1 for Bug 30713

Seems OK.

I'm not sure it's good to have all these cases, this one included, where the type PlatformReadWriteLock defined to be void*. If we're going to omit ReadWriteLock, then I suggest we do that in the header too rather than compiling a useless ReadWriteLock.

What's more, I can't find any code using ReadWriteLock anywhere in the WebKit source code nor in Safari's source code. It looks like Hyatt added this class but never started using it.

This patch is fine, but I think we could also consider dropping this unused code.

I see that Mark Rowe said the same thing in his recent comment.

[Steve Block]

> What's more, I can't find any code using ReadWriteLock anywhere in the WebKit
> source code nor in Safari's source code.
I wasn't sure if Hyatt was still working on the code that makes use of this class.

I'll commit this patch, but if Hyatt can confirm that the class isn't needed, I'll happily send a patch to remove it completely.

[WebKit Commit Bot]

Comment on attachment 41723 [details]
Patch 1 for Bug 30713

Clearing flags on attachment: 41723

Committed r50052: <http://trac.webkit.org/changeset/50052>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.