Bug 101607 – Web Inspector: stop using cursorCoords in CodeMirrorTextEditor

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Jan Keromnes]

In CodeMirror v3, the API changed, and the method instance.cursorCoords(start) doesn't return what we expect anymore. We should use instance.getCursor(start) instead.

[Jan Keromnes]

(In reply to comment #6 bug 99319)
> (From update of attachment 173038 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173038&action=review
> 
> > Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:-57
> > -    CodeMirror.on(this._codeMirror, "change", this._change.bind(this));
> 
> Why this was wrong? It seems to work for me.

Using the global `CodeMirror.on(instance, event)` function C-style is not wrong, but I think that the `instance.on(event)` variant is less confusing.

[Jan Keromnes]

Created attachment 173048 [details]
Patch

[WebKit Review Bot]

Comment on attachment 173048 [details]
Patch

Rejecting attachment 173048 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14770257

[Jan Keromnes]

Created attachment 173058 [details]
Patch

[WebKit Review Bot]

Comment on attachment 173058 [details]
Patch

Clearing flags on attachment: 173058

Committed r134014: <http://trac.webkit.org/changeset/134014>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.