Bug 101532 - [Qt][CSS Shaders] Make custom filter render in Wk1 mode
Summary: [Qt][CSS Shaders] Make custom filter render in Wk1 mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-07 17:52 PST by Alexandru Chiculita
Modified: 2013-01-15 02:03 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.43 KB, patch)
2013-01-14 10:24 PST, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2012-11-07 17:52:11 PST 
Currently, there's no way to enable custom filters in Wk1 mode. Also, it looks like WebGL fails to instantiate when running in that mode.
Comment 1 Allan Sandfeld Jensen 2013-01-14 01:55:37 PST 
They are enabled by default when WebGL is enabled. They do however fail or cause crashes because BitmapTextureImageBuffer::applyFilter tries to build the FilterEffectRenderer without a Document pointer.
Comment 2 Allan Sandfeld Jensen 2013-01-14 09:09:29 PST 
(In reply to comment #1)
> They are enabled by default when WebGL is enabled. They do however fail or cause crashes because BitmapTextureImageBuffer::applyFilter tries to build the FilterEffectRenderer without a Document pointer.

That is bug #106796, but only applies when non-GL TextureMapper is used. There is also a problem even with the GL TextureMapper.
Comment 3 Allan Sandfeld Jensen 2013-01-14 10:24:04 PST 
Created attachment 182598 [details]
Patch
Comment 4 WebKit Review Bot 2013-01-15 02:03:24 PST 
Comment on attachment 182598 [details]
Patch

Clearing flags on attachment: 182598

Committed r139731: <http://trac.webkit.org/changeset/139731>
Comment 5 WebKit Review Bot 2013-01-15 02:03:28 PST 
All reviewed patches have been landed.  Closing bug.