Bug 106796 – [TexMap] Composited CSS shaders crash when using non-GL TextureMapper

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Allan Sandfeld Jensen]

If custom CSS filter aka CSS shaders are used together with animations, they will fail to work or crash.

The problem appears to be caused by BitmapTextureImageBuffer trying to build a FilterEffectRenderer and passing a null pointer RenderObject. This will work for all other filters than custom ones. In custom ones it will fail to build a valid filter, which then causes FilterEffectRenderer::apply() to crash.

[Allan Sandfeld Jensen]

Created attachment 182739 [details]
Patch

[Jocelyn Turcotte]

Comment on attachment 182739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182739&action=review

> Source/WebCore/rendering/FilterEffectRenderer.cpp:424
> +    if (!effect)
> +        return;

By looking at the rest of FilterEffectRenderer, it looks like lastEffect is expected not to be null, so I'm not sure if this is the best fix longer term.
It feels like none of this code makes sense if the list of effect is empty. Is there a way you could fix it at the caller?

[Allan Sandfeld Jensen]

(In reply to comment #2)
> (From update of attachment 182739 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182739&action=review
> 
> > Source/WebCore/rendering/FilterEffectRenderer.cpp:424
> > +    if (!effect)
> > +        return;
> 
> By looking at the rest of FilterEffectRenderer, it looks like lastEffect is expected not to be null, so I'm not sure if this is the best fix longer term.
> It feels like none of this code makes sense if the list of effect is empty. Is there a way you could fix it at the caller?

The rest of the patch is fixing it at the caller, so this change on it is own is not needed to fix the crash (though it was here it crashed), but since a FilterEffectRenderer can be left "invalid" after a failed build() call, I felt it would be a good idea not to crash on a state that FilterEffectRenderer has left itself in.

[Allan Sandfeld Jensen]

Created attachment 182782 [details]
Patch

[Allan Sandfeld Jensen]

Committed r139864: <http://trac.webkit.org/changeset/139864>