Bug 100935 - [Meta] BaseDateAndTimeInputType should not inherit from TextFieldInputType
Summary: [Meta] BaseDateAndTimeInputType should not inherit from TextFieldInputType
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 100910 101007 101031 101038 101039 101196 101722 101886 106306
Blocks: 29359
  Show dependency treegraph
 
Reported: 2012-11-01 02:35 PDT by Kent Tamura
Modified: 2013-01-11 04:23 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-11-01 02:35:32 PDT
We don't represent date/time input types as text fields any more.
Comment 1 Kent Tamura 2012-11-02 07:31:42 PDT
Implementation of Date/time input types in Chromium-Android is hacky. We intercepts input events for the input types at outside of WebKit, and opens date/time pickers provided by Android system.  I guess iOS uses a similar way.

WebCore has interfaces to handle date/time chooser; ChromeClient::openDateTimeChooser, DateTimeChooser, and DateTimeChooserClient.

* Date/time types are not textfields essentially. BaseDateAndTimeInputType should stop inheriting from TextFieldInputType. It wastes memory.  A text block with -webkit-appearance:menulist would be enough.

* Use the existing date/time chooser interfaces, and stop the hack in Chromium-Android.
Comment 2 Hajime Morrita 2012-11-02 07:43:08 PDT
So we are going to eliminate text fields in such input elements for some platforms like Android, right?
That sounds reasonable change.
Comment 3 Kent Tamura 2013-01-11 04:23:48 PST
Completed all of changes.