Bug 100910 - Remove unused Locale::parseDateTime
Summary: Remove unused Locale::parseDateTime
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 100935
  Show dependency treegraph
 
Reported: 2012-10-31 18:55 PDT by Kent Tamura
Modified: 2012-11-01 02:37 PDT (History)
4 users (show)

See Also:


Attachments
Patch (22.37 KB, patch)
2012-10-31 19:03 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff
Patch for landing (22.87 KB, patch)
2012-10-31 23:55 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-10-31 18:55:31 PDT
Remove unused Locale::parseDateTime
Comment 1 Kent Tamura 2012-10-31 19:03:33 PDT
Created attachment 171756 [details]
Patch
Comment 2 Kentaro Hara 2012-10-31 23:27:10 PDT
Comment on attachment 171756 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171756&action=review

> Source/WebCore/ChangeLog:7
> +

Would you describe why parseDateTime() is unused? (I wonder why.)
Comment 3 Kent Tamura 2012-10-31 23:45:33 PDT
Comment on attachment 171756 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171756&action=review

>> Source/WebCore/ChangeLog:7
>> +
> 
> Would you describe why parseDateTime() is unused? (I wonder why.)

The comment in BaseDateAndTimeInputType::convertFromVisibleValue explains it.  I'll explain in ChangeLog too.
Comment 4 Kentaro Hara 2012-10-31 23:52:07 PDT
Comment on attachment 171756 [details]
Patch

Makes sense.
Comment 5 Kent Tamura 2012-10-31 23:55:59 PDT
Created attachment 171782 [details]
Patch for landing

Update ChangeLog
Comment 6 WebKit Review Bot 2012-11-01 00:32:20 PDT
Comment on attachment 171782 [details]
Patch for landing

Clearing flags on attachment: 171782

Committed r133134: <http://trac.webkit.org/changeset/133134>
Comment 7 WebKit Review Bot 2012-11-01 00:32:24 PDT
All reviewed patches have been landed.  Closing bug.