Bug 100931 - [EFL][MiniBrowser] Add encoding detector option.
Summary: [EFL][MiniBrowser] Add encoding detector option.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on: 100066 101450
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-01 02:25 PDT by Kangil Han
Modified: 2012-11-08 02:25 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.06 KB, patch)
2012-11-07 04:05 PST, Kangil Han 		no flags Details | Formatted Diff | Diff
Patch (4.08 KB, patch)
2012-11-07 18:48 PST, Kangil Han 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2012-11-01 02:25:22 PDT 
This is continuous work from BUG 98726.
Comment 1 Kangil Han 2012-11-07 04:05:42 PST 
Created attachment 172755 [details]
Patch
Comment 2 Gyuyoung Kim 2012-11-07 04:21:55 PST 
Comment on attachment 172755 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172755&action=review

> Tools/MiniBrowser/efl/main.c:939
> +    ewk_setting_encoding_detector_enabled_set(settings, encoding_detector_enabled);

Hmm, this API is only using ewk_setting instead of ewk_setings. Why don't we change this in new bug as well ?
Comment 3 Kangil Han 2012-11-07 18:48:07 PST 
Created attachment 172916 [details]
Patch
Comment 4 WebKit Review Bot 2012-11-08 02:25:43 PST 
Comment on attachment 172916 [details]
Patch

Clearing flags on attachment: 172916

Committed r133871: <http://trac.webkit.org/changeset/133871>
Comment 5 WebKit Review Bot 2012-11-08 02:25:46 PST 
All reviewed patches have been landed.  Closing bug.