Bug 100907 - Coordinated Graphics: Clean up headers of Coordinated Graphics.
Summary: Coordinated Graphics: Clean up headers of Coordinated Graphics.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dongseong Hwang
URL:
Keywords:
Depends on: 100995
Blocks: 100341 100797 100819
  Show dependency tree / graph
 
Reported: 2012-10-31 17:57 PDT by Dongseong Hwang
Modified: 2012-11-02 00:39 PDT (History)
4 users (show)

See Also:

Attachments
Patch (16.70 KB, patch)
2012-10-31 17:59 PDT, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
Patch (16.67 KB, patch)
2012-10-31 23:34 PDT, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2012-10-31 17:57:27 PDT 
This patch performs:
1. Remove unused method declarations.
2. Change public methods to private if needed.
3. Put virtual, OVERRIDE and explicit keywords if needed.
Comment 1 Dongseong Hwang 2012-10-31 17:59:47 PDT 
Created attachment 171748 [details]
Patch
Comment 2 Dongseong Hwang 2012-10-31 23:34:26 PDT 
Created attachment 171778 [details]
Patch
Comment 3 WebKit Review Bot 2012-11-01 08:56:15 PDT 
Comment on attachment 171778 [details]
Patch

Clearing flags on attachment: 171778

Committed r133182: <http://trac.webkit.org/changeset/133182>
Comment 4 WebKit Review Bot 2012-11-01 08:56:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2012-11-01 13:59:43 PDT 
It broks the Qt Mac build, please fix it as soon as possible... and watch the bots next time.
Comment 6 Csaba Osztrogonác 2012-11-01 14:02:44 PDT 
and the Qt win build too
Comment 7 Nandor Huszka 2012-11-01 15:25:04 PDT 
I've created a bug for the build fix: https://bugs.webkit.org/show_bug.cgi?id=100995
Comment 8 Dongseong Hwang 2012-11-01 16:24:41 PDT 
(In reply to comment #6)
> and the Qt win build too

(In reply to comment #7)
> I've created a bug for the build fix: https://bugs.webkit.org/show_bug.cgi?id=100995

Sorry to bothering you.
Thank for reporting and bug fix.