Bug 100905 - CoordinatedGraphicsArgumentCoders should use ValidatedCustomFitlerOperation instead
Summary: CoordinatedGraphicsArgumentCoders should use ValidatedCustomFitlerOperation i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandru Chiculita
URL:
Keywords:
Depends on: 100533 100906
Blocks: 74651 98990 101071
  Show dependency tree / graph
 
Reported: 2012-10-31 17:25 PDT by Alexandru Chiculita
Modified: 2012-11-07 10:30 PST (History)
5 users (show)

See Also:

Attachments
Patch V1 (8.14 KB, patch)
2012-11-02 13:41 PDT, Alexandru Chiculita 		noam: review+
noam: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2012-10-31 17:25:15 PDT 
CoordinatedGraphicsArgumentCoders uses the CustomFilterOperation, but it will never receive it anymore. It needs to be updated to use the ValidatedCustomFilterOperation instead.
Comment 1 Dongseong Hwang 2012-11-01 16:35:30 PDT 
Thank you for filing this bug. I can do it. Could I do?
Comment 2 Alexandru Chiculita 2012-11-02 13:41:04 PDT 
Created attachment 172128 [details]
Patch V1
Comment 3 Noam Rosenthal 2012-11-02 16:04:43 PDT 
Comment on attachment 172128 [details]
Patch V1

View in context: https://bugs.webkit.org/attachment.cgi?id=172128&action=review

LGTM

> Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.h:83
> +    const String& validatedVertexShader() const { ASSERT(m_isInitialized); return m_validatedVertexShader; }
> +    const String& validatedFragmentShader() const { ASSERT(m_isInitialized); return m_validatedFragmentShader; }

These functions deserve some more line breaks :)
Comment 4 Alexandru Chiculita 2012-11-07 10:30:11 PST 
Landed manually in http://trac.webkit.org/changeset/133777.