Bug 100793 - clean up tests for webkit-patch rebaseline* commands
Summary: clean up tests for webkit-patch rebaseline* commands
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 100562
  Show dependency treegraph
 
Reported: 2012-10-30 15:13 PDT by Dirk Pranke
Modified: 2012-10-30 16:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (55.88 KB, patch)
2012-10-30 15:15 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
Patch (22.49 KB, patch)
2012-10-30 15:23 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
rename klass to command_constructor (55.96 KB, patch)
2012-10-30 15:44 PDT, Dirk Pranke
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-10-30 15:13:00 PDT
clean up tests for webkit-patch rebaseline* commands
Comment 1 Dirk Pranke 2012-10-30 15:15:31 PDT
Created attachment 171526 [details]
Patch
Comment 2 Ojan Vafai 2012-10-30 15:19:50 PDT
Comment on attachment 171526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171526&action=review

> Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:41
> +    klass = None

klass?
Comment 3 Ojan Vafai 2012-10-30 15:22:06 PDT
Comment on attachment 171526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171526&action=review

>> Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:41
>> +    klass = None
> 
> klass?

Sorry, I understand why not "class", but why not a descriptive name, e.g. commandConstructor?
Comment 4 Dirk Pranke 2012-10-30 15:23:47 PDT
Created attachment 171529 [details]
Patch
Comment 5 Dirk Pranke 2012-10-30 15:26:08 PDT
Comment on attachment 171529 [details]
Patch

wrong bug, ignore.
Comment 6 Dirk Pranke 2012-10-30 15:27:11 PDT
(In reply to comment #3)
> (From update of attachment 171526 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171526&action=review
> 
> >> Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:41
> >> +    klass = None
> > 
> > klass?
> 
> Sorry, I understand why not "class", but why not a descriptive name, e.g. commandConstructor?

"klass" is a pretty common python name for a variable that points to a class object, but I can change it to commandConstructor if you think that's better ...
Comment 7 Dirk Pranke 2012-10-30 15:44:30 PDT
Created attachment 171538 [details]
rename klass to command_constructor
Comment 8 Ojan Vafai 2012-10-30 15:52:05 PDT
Comment on attachment 171538 [details]
rename klass to command_constructor

FWIW, tony was happy with klass. I'm happier now though. :)
Comment 9 Dirk Pranke 2012-10-30 16:22:25 PDT
Committed r132957: <http://trac.webkit.org/changeset/132957>