clean up tests for webkit-patch rebaseline* commands
Created attachment 171526 [details] Patch
Comment on attachment 171526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171526&action=review > Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:41 > + klass = None klass?
Comment on attachment 171526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171526&action=review >> Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:41 >> + klass = None > > klass? Sorry, I understand why not "class", but why not a descriptive name, e.g. commandConstructor?
Created attachment 171529 [details] Patch
Comment on attachment 171529 [details] Patch wrong bug, ignore.
(In reply to comment #3) > (From update of attachment 171526 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=171526&action=review > > >> Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:41 > >> + klass = None > > > > klass? > > Sorry, I understand why not "class", but why not a descriptive name, e.g. commandConstructor? "klass" is a pretty common python name for a variable that points to a class object, but I can change it to commandConstructor if you think that's better ...
Created attachment 171538 [details] rename klass to command_constructor
Comment on attachment 171538 [details] rename klass to command_constructor FWIW, tony was happy with klass. I'm happier now though. :)
Committed r132957: <http://trac.webkit.org/changeset/132957>