Bug 100562 - webkit-patch rebaseline*: add more helpful logging
Summary: webkit-patch rebaseline*: add more helpful logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on: 100793
Blocks: 100563
  Show dependency treegraph
 
Reported: 2012-10-26 14:28 PDT by Dirk Pranke
Modified: 2012-10-30 16:24 PDT (History)
4 users (show)

See Also:


Attachments
Patch (19.14 KB, patch)
2012-10-26 14:30 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
Patch (22.82 KB, patch)
2012-10-30 15:25 PDT, Dirk Pranke
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-10-26 14:28:20 PDT
webkit-patch rebaseline*: add more helpful logging
Comment 1 Dirk Pranke 2012-10-26 14:30:14 PDT
Created attachment 171010 [details]
Patch
Comment 2 Dirk Pranke 2012-10-26 14:30:58 PDT
Comment on attachment 171010 [details]
Patch

this patch isn't fully ready for review/landing yet, a bunch of the tests still fail and I need to see if I need to add any new tests.
Comment 3 Dirk Pranke 2012-10-30 15:25:21 PDT
Created attachment 171530 [details]
Patch
Comment 4 Ojan Vafai 2012-10-30 15:57:06 PDT
Comment on attachment 171530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171530&action=review

> Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py:200
> +        platform_dir = 'LayoutTests' + self._filesystem.sep + 'platform' + self._filesystem.sep

Why not join?
Comment 5 Dirk Pranke 2012-10-30 16:24:57 PDT
Committed r132959: <http://trac.webkit.org/changeset/132959>