WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
100787
test-webkitpy: fix running modules and classes on the command line
https://bugs.webkit.org/show_bug.cgi?id=100787
Summary
test-webkitpy: fix running modules and classes on the command line
Dirk Pranke
Reported
2012-10-30 14:34:02 PDT
test-webkitpy: fix running modules and classes on the command line
Attachments
Patch
(5.45 KB, patch)
2012-10-30 14:34 PDT
,
Dirk Pranke
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2012-10-30 14:34:44 PDT
Created
attachment 171520
[details]
Patch
Eric Seidel (no email)
Comment 2
2012-10-30 14:37:59 PDT
What is a serial integration test? Integration tests were a jail we created to avoid running slow tests all the time. I'm surprised we're adding more support for such.
Dirk Pranke
Comment 3
2012-10-30 14:52:38 PDT
(In reply to
comment #2
)
> What is a serial integration test? Integration tests were a jail we created to avoid running slow tests all the time. I'm surprised we're adding more support for such.
There were/are two kinds of integration tests. The first kind was tests that were slow, and those have almost all been reworked and are all fast (but there's a few left, I think mostly in the committers.py code). The second kind are true integration tests that test that real commands actually do work (like starting and stopping HTTP servers, etc.) and rely on things in the real filesystem or checkout. These are off by default but are useful. Of these tests, there are some that can be run in parallel and some that can't (just like the regular unit tests). At the moment, there are no tests marked serial_integration, but that's probably bad, as some of the http tests should probably be marked that way.
Eric Seidel (no email)
Comment 4
2012-10-31 11:33:09 PDT
Comment on
attachment 171520
[details]
Patch rs=me.
Dirk Pranke
Comment 5
2012-10-31 12:01:50 PDT
Committed
r133055
: <
http://trac.webkit.org/changeset/133055
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug