Bug 100661 - [Qt][WK2] REGRESSION(r132640): It made tst_QQuickWebView::removeFromCanvas() timeout.
Summary: [Qt][WK2] REGRESSION(r132640): It made tst_QQuickWebView::removeFromCanvas()...
Status: RESOLVED DUPLICATE of bug 100672
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: All All
: P1 Blocker
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 70236 76773 100495
  Show dependency tree / graph
 
Reported: 2012-10-29 05:54 PDT by Csaba Osztrogonác
Modified: 2012-10-29 09:45 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-10-29 05:54:16 PDT 
After https://trac.webkit.org/changeset/132640 tst_QQuickWebView::removeFromCanvas()
 started to fail with timeout:

********* Start testing of tst_QQuickWebView *********
Config: Using QTest library 5.0.0, Qt 5.0.0
...
QFATAL : tst_QQuickWebView::removeFromCanvas() Received signal 15
FAIL!  : tst_QQuickWebView::removeFromCanvas() Received a fatal error.
   Loc: [Unknown file(0)]
Totals: 16 passed, 1 failed, 0 skipped
********* Finished testing of tst_QQuickWebView *********

I tried to revert r132640 locally, and then this test case always passes,
but another test case started to fail later:
********* Start testing of tst_QQuickWebView *********
Config: Using QTest library 5.0.0, Qt 5.0.0
...
PASS   : tst_QQuickWebView::removeFromCanvas()
...
QFATAL : tst_QQuickWebView::basicRenderingSanity() Received signal 11
FAIL!  : tst_QQuickWebView::basicRenderingSanity() Received a fatal error.
   Loc: [Unknown file(0)]
Totals: 23 passed, 1 failed, 0 skipped
********* Finished testing of tst_QQuickWebView *********
Comment 1 Jocelyn Turcotte 2012-10-29 05:57:34 PDT 
(In reply to comment #0)
Yep it was a fix for basicRenderingSanity but all tests seemed to pass on my desktop. I'm seeing another case where directly composited images are causing a crash, I'll check if I can fix removeFromCanvas too.
Comment 2 Jocelyn Turcotte 2012-10-29 09:33:56 PDT 
Arf, webkit-patch reopened the other bug and used it for the patch for some reason.
Anyway, it got fixed in <http://trac.webkit.org/changeset/132801>

Resolving as duplicate even though this is the bug written in the ChangeLog.

*** This bug has been marked as a duplicate of bug 100672 ***
Comment 3 Csaba Osztrogonác 2012-10-29 09:37:14 PDT 
I really don't understand why you always file one more bug report ... :)
Why wasn't it good for you to fix the bug?
Comment 4 Csaba Osztrogonác 2012-10-29 09:38:43 PDT 
I meant changing the title of the bug.
Comment 5 Jocelyn Turcotte 2012-10-29 09:45:14 PDT 
(In reply to comment #3)
> I really don't understand why you always file one more bug report ... :)
> Why wasn't it good for you to fix the bug?

Nah I didn't want to this time, but webkit-patch creates one automatically except when running prepare-changelogs beforehand. Just forgot and then I probably didn't restart it after having closed the bug and changed the bug url in the changelog.