Similar to bug 99478, we'd need to initialize the timeout flag from the CFError in order for XHR timeouts to work (Bug 74802).
Created attachment 170583 [details] Patch
Roger, do you have an Apple Win build where you could test this?
This should fix the failures on the Apple Win 7 Release bot for the following test cases: http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html
Alternatively, can we commit this experimentally and see whether the tests then pass on the bot?
Comment on attachment 170583 [details] Patch > Alternatively, can we commit this experimentally and see whether the tests then pass on the bot? I think that we should.
Comment on attachment 170583 [details] Patch Clearing flags on attachment: 170583 Committed r132493: <http://trac.webkit.org/changeset/132493>
All reviewed patches have been landed. Closing bug.
Looks like it didn't quite cut it, but there's some hiccup with the buildmaster, let's have a look later again: http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/29256
Ah, sorry, I do have a windows build. I'll test it out there as well.
still broken, is there a feature define I need to enable?
Re-opened since this is blocked by bug 100509
Experimental fix rolled out in r132630.
Skipped for Win in r132638.
(In reply to comment #10) > still broken, is there a feature define I need to enable? There wasn't, but now there is, cmp. http://trac.webkit.org/changeset/132513 I currently have no build to test or work on this. If you'd like to take a look, the issue most like is just about checking what error code is CFNetworking is returning and then intializing the ResourceErrorBase's m_isTimeout to true, similar to the patch I tried.
See also Bug 102271.
*** This bug has been marked as a duplicate of bug 102271 ***