Bug 100199 - [EFL][WK2] Make find and form clients C++ classes
Summary: [EFL][WK2] Make find and form clients C++ classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 99992
  Show dependency tree / graph
 
Reported: 2012-10-23 22:39 PDT by Chris Dumez
Modified: 2012-10-24 04:02 PDT (History)
4 users (show)

See Also:

Attachments
Patch (24.15 KB, patch)
2012-10-23 23:44 PDT, Chris Dumez 		gyuyoung.kim: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (24.18 KB, patch)
2012-10-24 02:52 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-23 22:39:22 PDT 
As part of bug 99992, we should move away from C'ism and make the find client a C++ class.
Comment 1 Chris Dumez 2012-10-23 23:44:37 PDT 
Created attachment 170328 [details]
Patch
Comment 2 Mikhail Pozdnyakov 2012-10-24 00:07:42 PDT 
Comment on attachment 170328 [details]
Patch

looks nice
Comment 3 WebKit Review Bot 2012-10-24 01:14:20 PDT 
Comment on attachment 170328 [details]
Patch

Rejecting attachment 170328 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
44>At revision 63.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14566117
Comment 4 Chris Dumez 2012-10-24 02:52:56 PDT 
Created attachment 170350 [details]
Patch for landing

Rebase on master. Could someone please cq+?
Comment 5 WebKit Review Bot 2012-10-24 04:02:23 PDT 
Comment on attachment 170350 [details]
Patch for landing

Clearing flags on attachment: 170350

Committed r132334: <http://trac.webkit.org/changeset/132334>
Comment 6 WebKit Review Bot 2012-10-24 04:02:29 PDT 
All reviewed patches have been landed.  Closing bug.