RESOLVED FIXED 100093
[EFL][WK2] Make request manager client a C++ class 
https://bugs.webkit.org/show_bug.cgi?id=100093
Summary [EFL][WK2] Make request manager client a C++ class
Chris Dumez
Reported 2012-10-23 02:20:42 PDT
As part of bug 99992, we should move away from C'ism and make request manager client a C++ class.
Attachments
Patch (20.01 KB, patch)
2012-10-23 05:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch for landing (19.74 KB, patch)
2012-10-23 06:29 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-23 05:55:25 PDT
Created attachment 170138 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-10-23 05:59:32 PDT
Comment on attachment 170138 [details] Patch r=me
Mikhail Pozdnyakov
Comment 3 2012-10-23 06:01:10 PDT
Comment on attachment 170138 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170138&action=review > Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.cpp:72 > +{ maybe ASSERT(m_context) ? > Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.h:29 > +#include "ewk_context_private.h" class Ewk_Context; ? > Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.h:50 > + Ewk_Url_Scheme_Handler schemeHandler(const String& scheme) const; do you really need this method? > Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.h:56 > + typedef HashMap<String, Ewk_Url_Scheme_Handler> URLSchemeHandlerMap; typedef HashMap<String, class Ewk_Url_Scheme_Handler> ?
Chris Dumez
Comment 4 2012-10-23 06:29:14 PDT
Created attachment 170144 [details] Patch for landing Take into consideration feedback from Mikhail. Carrying over r+ over Kenneth. Could someone please cq+ ?
WebKit Review Bot
Comment 5 2012-10-23 06:52:24 PDT
Comment on attachment 170144 [details] Patch for landing Clearing flags on attachment: 170144 Committed r132217: <http://trac.webkit.org/changeset/132217>
WebKit Review Bot
Comment 6 2012-10-23 06:52:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.