Bug 100089 - [EFL][WK2] Make Policy client a C++ class
Summary: [EFL][WK2] Make Policy client a C++ class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks: 99992
  Show dependency tree / graph
 
Reported: 2012-10-23 01:32 PDT by Mikhail Pozdnyakov
Modified: 2012-10-23 05:32 PDT (History)
6 users (show)

See Also:

Attachments
patch (19.65 KB, patch)
2012-10-23 02:52 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
patch v2 (19.56 KB, patch)
2012-10-23 03:02 PDT, Mikhail Pozdnyakov 		kenneth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
to be landed (19.62 KB, patch)
2012-10-23 05:06 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
rebased (19.59 KB, patch)
2012-10-23 05:07 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-10-23 01:32:23 PDT 
As part of https://bugs.webkit.org/show_bug.cgi?id=99992, we should convert the policy client to C++.
Comment 1 Mikhail Pozdnyakov 2012-10-23 02:52:59 PDT 
Created attachment 170100 [details]
patch
Comment 2 WebKit Review Bot 2012-10-23 02:56:46 PDT 
Attachment 170100 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/efl/PagePolicyClientEfl.h:45:  The parameter name "navigationType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/efl/PagePolicyClientEfl.h:45:  The parameter name "modifiers" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/efl/PagePolicyClientEfl.h:45:  The parameter name "mouseButton" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/efl/PagePolicyClientEfl.h:45:  The parameter name "request" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/efl/PagePolicyClientEfl.h:45:  The parameter name "listener" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 5 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mikhail Pozdnyakov 2012-10-23 03:02:31 PDT 
Created attachment 170102 [details]
patch v2

removed unnecessary parameters to satisfy style checker
Comment 4 Chris Dumez 2012-10-23 03:14:05 PDT 
Comment on attachment 170102 [details]
patch v2

LGTM.
Comment 5 WebKit Review Bot 2012-10-23 04:08:05 PDT 
Comment on attachment 170102 [details]
patch v2

Rejecting attachment 170102 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 12787 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
50>At revision 12787.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14491827
Comment 6 Mikhail Pozdnyakov 2012-10-23 05:06:00 PDT 
Created attachment 170128 [details]
to be landed
Comment 7 Mikhail Pozdnyakov 2012-10-23 05:07:54 PDT 
Created attachment 170129 [details]
rebased
Comment 8 WebKit Review Bot 2012-10-23 05:32:00 PDT 
Comment on attachment 170129 [details]
rebased

Clearing flags on attachment: 170129

Committed r132208: <http://trac.webkit.org/changeset/132208>
Comment 9 WebKit Review Bot 2012-10-23 05:32:04 PDT 
All reviewed patches have been landed.  Closing bug.