RESOLVED FIXED 100089
[EFL][WK2] Make Policy client a C++ class 
https://bugs.webkit.org/show_bug.cgi?id=100089
Summary [EFL][WK2] Make Policy client a C++ class
Mikhail Pozdnyakov
Reported 2012-10-23 01:32:23 PDT
As part of https://bugs.webkit.org/show_bug.cgi?id=99992, we should convert the policy client to C++.
Attachments
patch (19.65 KB, patch)
2012-10-23 02:52 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
patch v2 (19.56 KB, patch)
2012-10-23 03:02 PDT, Mikhail Pozdnyakov 		kenneth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
to be landed (19.62 KB, patch)
2012-10-23 05:06 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
rebased (19.59 KB, patch)
2012-10-23 05:07 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-10-23 02:52:59 PDT
Created attachment 170100 [details] patch
WebKit Review Bot
Comment 2 2012-10-23 02:56:46 PDT
Attachment 170100 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/efl/PagePolicyClientEfl.h:45: The parameter name "navigationType" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/efl/PagePolicyClientEfl.h:45: The parameter name "modifiers" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/efl/PagePolicyClientEfl.h:45: The parameter name "mouseButton" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/efl/PagePolicyClientEfl.h:45: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/efl/PagePolicyClientEfl.h:45: The parameter name "listener" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 5 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mikhail Pozdnyakov
Comment 3 2012-10-23 03:02:31 PDT
Created attachment 170102 [details] patch v2 removed unnecessary parameters to satisfy style checker
Chris Dumez
Comment 4 2012-10-23 03:14:05 PDT
Comment on attachment 170102 [details] patch v2 LGTM.
WebKit Review Bot
Comment 5 2012-10-23 04:08:05 PDT
Comment on attachment 170102 [details] patch v2 Rejecting attachment 170102 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 12787 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 12787. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14491827
Mikhail Pozdnyakov
Comment 6 2012-10-23 05:06:00 PDT
Created attachment 170128 [details] to be landed
Mikhail Pozdnyakov
Comment 7 2012-10-23 05:07:54 PDT
Created attachment 170129 [details] rebased
WebKit Review Bot
Comment 8 2012-10-23 05:32:00 PDT
Comment on attachment 170129 [details] rebased Clearing flags on attachment: 170129 Committed r132208: <http://trac.webkit.org/changeset/132208>
WebKit Review Bot
Comment 9 2012-10-23 05:32:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.