RESOLVED FIXED 100076
exif-orientation tests should use dumpAsText(true) 
https://bugs.webkit.org/show_bug.cgi?id=100076
Summary exif-orientation tests should use dumpAsText(true)
noel gordon
Reported 2012-10-22 22:50:22 PDT
The fast/images/exif-orientation tests use dumpAsText(1). That's not supported by chromium DRT so NRWT --chromium won't compare the expected pixel results if/when we unskip these tests.
Attachments
Patch (1.73 KB, patch)
2012-10-23 18:22 PDT, noel gordon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
noel gordon
Comment 1 2012-10-23 18:22:53 PDT
Created attachment 170281 [details] Patch
Eric Seidel (no email)
Comment 2 2012-10-23 18:42:11 PDT
Comment on attachment 170281 [details] Patch Do some DRT implementations care?
Eric Seidel (no email)
Comment 3 2012-10-23 18:42:43 PDT
Seems reasonable to make chromium DRT support this. :)
noel gordon
Comment 4 2012-10-23 19:13:09 PDT
(In reply to comment #2) > Do some DRT implementations care? Chromium DRT doesn't understand an integer argument, it only handles booleans. http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp?rev=132138#L359
noel gordon
Comment 5 2012-10-23 19:15:38 PDT
(In reply to comment #3) > Seems reasonable to make chromium DRT support this. :) Yes, we could that after Stephen fixes the only remaining test using dumpAsText(1) per bug 100074
noel gordon
Comment 6 2012-10-23 19:36:34 PDT
After that, change the DRTTestRunner.cpp?rev=132138#L359 code to read - if (arguments.size() > 0 && arguments[0].isBool()) - m_generatePixelResults = arguments[0].value.boolValue; + if (arguments.size() > 0) + m_generatePixelResults = cppVariantToBool(arguments[0]);
WebKit Review Bot
Comment 7 2012-10-23 21:09:28 PDT
Comment on attachment 170281 [details] Patch Clearing flags on attachment: 170281 Committed r132297: <http://trac.webkit.org/changeset/132297>
WebKit Review Bot
Comment 8 2012-10-23 21:09:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.