Bug 100076 - exif-orientation tests should use dumpAsText(true)
Summary: exif-orientation tests should use dumpAsText(true)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: noel gordon
URL:
Keywords:
Depends on:
Blocks: 100191
  Show dependency treegraph
 
Reported: 2012-10-22 22:50 PDT by noel gordon
Modified: 2012-10-23 21:31 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.73 KB, patch)
2012-10-23 18:22 PDT, noel gordon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2012-10-22 22:50:22 PDT
The fast/images/exif-orientation tests use dumpAsText(1).  That's not supported by chromium DRT so NRWT --chromium won't compare the expected pixel results if/when we unskip these tests.
Comment 1 noel gordon 2012-10-23 18:22:53 PDT
Created attachment 170281 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-10-23 18:42:11 PDT
Comment on attachment 170281 [details]
Patch

Do some DRT implementations care?
Comment 3 Eric Seidel (no email) 2012-10-23 18:42:43 PDT
Seems reasonable to make chromium DRT support this. :)
Comment 4 noel gordon 2012-10-23 19:13:09 PDT
(In reply to comment #2)

> Do some DRT implementations care?

Chromium DRT doesn't understand an integer argument, it only handles booleans.

http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp?rev=132138#L359
Comment 5 noel gordon 2012-10-23 19:15:38 PDT
(In reply to comment #3)
> Seems reasonable to make chromium DRT support this. :)

Yes, we could that after Stephen fixes the only remaining test using dumpAsText(1) per bug 100074
Comment 6 noel gordon 2012-10-23 19:36:34 PDT
After that, change the DRTTestRunner.cpp?rev=132138#L359 code to read

-    if (arguments.size() > 0 && arguments[0].isBool())
-        m_generatePixelResults = arguments[0].value.boolValue;
+    if (arguments.size() > 0)
+        m_generatePixelResults = cppVariantToBool(arguments[0]);
Comment 7 WebKit Review Bot 2012-10-23 21:09:28 PDT
Comment on attachment 170281 [details]
Patch

Clearing flags on attachment: 170281

Committed r132297: <http://trac.webkit.org/changeset/132297>
Comment 8 WebKit Review Bot 2012-10-23 21:09:32 PDT
All reviewed patches have been landed.  Closing bug.