Bug 100074 – [chromium] svg/as-image/image-respects-pageScaleFactor-change.html should use dumpAsText(true)

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Tools / Tests

[noel gordon]

Test currently uses dumpAsText(1) but that's not supported by chromium DRT so NRWT won't compare the expected pixel results :/

[Stephen Chenney]

So dumpAsText(1) means dump as text and compare as image, but do not dump the render tree?

How 'bout that. I can try to get it implemented, or maybe Dirk has time.

Still, the test seems to me like it should be a ref-test, so I think I will make it so.

[noel gordon]

Change it to dumpAsText(true), that'll work everywhere.  Then submit new pixel results for chromium.

[Dirk Pranke]

As far as I know, dumpAsText(True) means do not dump a render tree and do not produce a pixel result, on all ports. I don't think there's a difference between dumpAsText(true) and dumpAsText(1), nor a way to get non-render-tree text output but still get a pixel result.

[noel gordon]

(In reply to comment #3)
> As far as I know, dumpAsText(True) means do not dump a render tree and do not produce a pixel result, on all ports.

It means dump text & pixels and do not dump render tree and yes, we admit it's confusing

http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree#Howtodisablerendertreedumpsbutkeeppixelsandtext


>  I don't think there's a difference between dumpAsText(true) and dumpAsText(1)

Agree; there should not be a difference.  However the chromium DRT only accepts a boolean and that creates a difference on the Chromium port :)  I can fix that later.

As suggested, just change this test to use dumpAsText(true), and check in new chromium pixel results.

I've fixed the other cases of dumpAsText(1) on bug 100076.

[Stephen Chenney]

Marked LayoutTest bugs, bugs with Chromium IDs, and some others as WontFix. Test failure bugs still are trackable via TestExpectations or disabled unit tests.