Bug 99982

Summary: [EFL][WK2] Make the resource load client a C++ class
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, mikhail.pozdnyakov, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99992    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2012-10-22 05:22:18 PDT
The Resource load client is currently tightly integrated to the view and uses C style. We should move all the resource load client code to its own C++ class.
Attachments
Patch (30.17 KB, patch)
2012-10-22 07:08 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (30.38 KB, patch)
2012-10-22 09:50 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-22 07:08:57 PDT
Created attachment 169904 [details] Patch
Chris Dumez
Comment 2 2012-10-22 09:03:23 PDT
Comment on attachment 169904 [details] Patch Will move the class to WebKit namespace.
Chris Dumez
Comment 3 2012-10-22 09:50:50 PDT
Created attachment 169929 [details] Patch Move client to WebKit namespace.
Kenneth Rohde Christiansen
Comment 4 2012-10-22 12:37:02 PDT
Comment on attachment 169929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169929&action=review r=me > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:839 > + priv->resourceLoadClient = ResourceLoadClientEfl::create(ewkView); why not call it ResourceLoaderClientEfl to show the relation to FrameLoaderClient > Source/WebKit2/UIProcess/efl/ResourceLoadClientEfl.cpp:131 > + WKPageResourceLoadClient wkResourceLoadClient; Ah I see now...
WebKit Review Bot
Comment 5 2012-10-22 12:53:18 PDT
Comment on attachment 169929 [details] Patch Clearing flags on attachment: 169929 Committed r132122: <http://trac.webkit.org/changeset/132122>
WebKit Review Bot
Comment 6 2012-10-22 12:53:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.