Bug 99804

Summary: Rename ENABLE_CSS3_TEXT_DECORATION to ENABLE_CSS3_TEXT
Product: WebKit Reporter: Dongwoo Joshua Im (dwim) <dw.im>
Component: CSSAssignee: Dongwoo Joshua Im (dwim) <dw.im>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, allan.jensen, bruno.abinader, cmarcelo, dbates, donggwan.kim, eric, gyuyoung.kim, jchaffraix, macpherson, menard, rakuco, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 99807    
Bug Blocks: 58491, 76173, 91638, 92000, 93507, 94094, 99439, 99948    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Dongwoo Joshua Im (dwim) 2012-10-18 21:53:33 PDT 
Regarding the discussion with jchaffraix on bug https://bugs.webkit.org/show_bug.cgi?id=99439,
I'd like to rename the flag ENABLE_CSS3_TEXT_DECORATION to ENABLE_CSS3_TEXT.

Under ENABLE_CSS3_TEXT flag, there could be implemented not only about text decoration,
but text alignment related features - such as text-align-last, and text-justify.
Comment 1 Dongwoo Joshua Im (dwim) 2012-10-18 22:44:55 PDT 
Created attachment 169549 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-18 22:46:55 PDT 
Attachment 169549 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1
LayoutTests/platform/qt-mac/TestExpectations:1521:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dongwoo Joshua Im (dwim) 2012-10-18 23:08:22 PDT 
Style error of the first patch is not related with this bug.

This error will be fixed by https://bugs.webkit.org/show_bug.cgi?id=99807.
Comment 4 Dongwoo Joshua Im (dwim) 2012-10-18 23:40:55 PDT 
Created attachment 169559 [details]
Patch
Comment 5 WebKit Review Bot 2012-10-18 23:43:40 PDT 
Attachment 169559 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1
LayoutTests/platform/qt-mac/TestExpectations:1521:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Dongwoo Joshua Im (dwim) 2012-10-18 23:59:51 PDT 
(In reply to comment #5)
> Attachment 169559 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1
> LayoutTests/platform/qt-mac/TestExpectations:1521:  Path does not exist.  [test/expectations] [5]
> Total errors found: 1 in 41 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Hmm.. same error again, although I've already fixed by another bug...
Comment 7 Dongwoo Joshua Im (dwim) 2012-10-19 01:21:08 PDT 
Created attachment 169571 [details]
Patch
Comment 8 WebKit Review Bot 2012-10-19 01:24:07 PDT 
Attachment 169571 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1
LayoutTests/platform/qt-mac/TestExpectations:1521:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Dongwoo Joshua Im (dwim) 2012-10-19 01:36:24 PDT 
(In reply to comment #8)
> Attachment 169571 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1
> LayoutTests/platform/qt-mac/TestExpectations:1521:  Path does not exist.  [test/expectations] [5]
> Total errors found: 1 in 41 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

This style error is not about this patch itself.
So,... I will forget about this.
Comment 10 Bruno Abinader (history only) 2012-10-19 10:15:06 PDT 
Interesting, I've applied your patch locally and then ran 'check-webkit-style' which shows 0 errors. Is this an issue from the style build bot itself?
Comment 11 Julien Chaffraix 2012-10-19 11:25:24 PDT 
Comment on attachment 169571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169571&action=review

> Interesting, I've applied your patch locally and then ran 'check-webkit-style' which shows 0 errors. Is this an issue from the style build bot itself?

Linting errors are usually resolved fast as they turn the bots red so the patch probably hit a bad revision. Note that you can check linting errors with new-run-webkit-tests --lint-test-files (which is run as part of check-webkit-style).

> LayoutTests/platform/qt-mac/TestExpectations:5808
> +# CSS3 Text support is not yet enabled (needs ENABLE_CSS3_TEXT).
>  webkit.org/b/58491 fast/css3-text-decoration

The error is line 1521 per the style bot so it's unrelated as you only touching around line 5808.
Comment 12 WebKit Review Bot 2012-10-19 11:53:19 PDT 
Comment on attachment 169571 [details]
Patch

Clearing flags on attachment: 169571

Committed r131925: <http://trac.webkit.org/changeset/131925>
Comment 13 WebKit Review Bot 2012-10-19 11:53:27 PDT 
All reviewed patches have been landed.  Closing bug.