Bug 99735

Summary: Add String version of visitedLinkHash() to properly handle 8-bit URL Strings.
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: WebCore Misc.Assignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, japhet, peter+ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 100008    
Bug Blocks:    
Attachments:
Description Flags
Patch
peter+ews: commit-queue-
Updated patch with speculative fix for chromium platform none

Michael Saboff
Reported 2012-10-18 10:51:51 PDT
By adding a String version of visitedLinkHash() we can eliminate up converting 8-bit URL Strings to 16-bits.
Attachments
Patch (5.87 KB, patch)
2012-10-18 10:57 PDT, Michael Saboff 		peter+ews: commit-queue-
DetailsFormatted DiffDiff
Updated patch with speculative fix for chromium platform (5.94 KB, patch)
2012-10-19 10:24 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-10-18 10:57:03 PDT
Created attachment 169437 [details] Patch
Peter Beverloo (cr-android ews)
Comment 2 2012-10-18 11:18:39 PDT
Comment on attachment 169437 [details] Patch Attachment 169437 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14461097
WebKit Review Bot
Comment 3 2012-10-18 11:24:24 PDT
Comment on attachment 169437 [details] Patch Attachment 169437 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14406032
Michael Saboff
Comment 4 2012-10-19 10:24:46 PDT
Created attachment 169645 [details] Updated patch with speculative fix for chromium platform
WebKit Review Bot
Comment 5 2012-10-19 16:21:47 PDT
Comment on attachment 169645 [details] Updated patch with speculative fix for chromium platform Clearing flags on attachment: 169645 Committed r131955: <http://trac.webkit.org/changeset/131955>
WebKit Review Bot
Comment 6 2012-10-19 16:21:51 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 7 2012-10-19 17:24:55 PDT
Comment on attachment 169645 [details] Updated patch with speculative fix for chromium platform View in context: https://bugs.webkit.org/attachment.cgi?id=169645&action=review > Source/WebCore/platform/chromium/LinkHashChromium.cpp:56 > + return (url.characters(), url.length()); This can’t be right. It’s a comma expression that will return the length.
Michael Saboff
Comment 8 2012-10-22 09:11:31 PDT
Need to update the chromium platform part of the change.
Michael Saboff
Comment 9 2012-10-22 14:09:21 PDT
Change set r132116: <http://trac.webkit.org/changeset/132116> to https://bugs.webkit.org/show_bug.cgi?id=100008 landed, fixing the chromium change.
Note You need to log in before you can comment on or make changes to this bug.