Summary: | Add String version of visitedLinkHash() to properly handle 8-bit URL Strings. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||||
Component: | WebCore Misc. | Assignee: | Michael Saboff <msaboff> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, japhet, peter+ews, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 100008 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Michael Saboff
2012-10-18 10:51:51 PDT
Created attachment 169437 [details]
Patch
Comment on attachment 169437 [details] Patch Attachment 169437 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14461097 Comment on attachment 169437 [details] Patch Attachment 169437 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14406032 Created attachment 169645 [details]
Updated patch with speculative fix for chromium platform
Comment on attachment 169645 [details] Updated patch with speculative fix for chromium platform Clearing flags on attachment: 169645 Committed r131955: <http://trac.webkit.org/changeset/131955> All reviewed patches have been landed. Closing bug. Comment on attachment 169645 [details] Updated patch with speculative fix for chromium platform View in context: https://bugs.webkit.org/attachment.cgi?id=169645&action=review > Source/WebCore/platform/chromium/LinkHashChromium.cpp:56 > + return (url.characters(), url.length()); This can’t be right. It’s a comma expression that will return the length. Need to update the chromium platform part of the change. Change set r132116: <http://trac.webkit.org/changeset/132116> to https://bugs.webkit.org/show_bug.cgi?id=100008 landed, fixing the chromium change. |